[codex] Fix Kimi subscription quota rows#1939
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed July 6, 2026, 9:02 AM ET / 13:02 UTC. Summary Reproducibility: no. high-confidence live reproduction is attached. Source inspection confirms current main still calls the endpoint the PR reports as returning 404 and only persists one Kimi extra widget row, but I did not run a real Kimi account probe. Review metrics: 2 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land a narrow Kimi provider/widget fix after redacted proof confirms Do we have a high-confidence way to reproduce the issue? No high-confidence live reproduction is attached. Source inspection confirms current main still calls the endpoint the PR reports as returning 404 and only persists one Kimi extra widget row, but I did not run a real Kimi account probe. Is this the best way to solve the issue? Unclear until proof is added: the implementation is the narrow source-level fix for the reported endpoint drift and missing extra row propagation, but the live endpoint contract and rendered result still need after-fix evidence. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against b00797537dbf. Label changesLabel changes:
Label justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
a2d9883 to
6ef7960
Compare
|
Thanks @skyzer! An improved version landed in #1953 as dcccce8, preserving your authorship and changelog credit. The original fork branch could not be updated because maintainer edits were disabled, so the repair had to land from a maintainer branch. Enabling “Allow edits by maintainers” on future PRs lets us improve the original branch directly. |
Summary
GetSubscriptionStatto the currentGetSubscriptionStatsendpoint so the Monthly subscription quota can populate again.ratelimitCode7dfrom Kimi membership stats and expose it as a separateCode 7-dayextra quota row.Root Cause
Kimi now returns
404forMembershipService/GetSubscriptionStat. The live membership quota page callsMembershipService/GetSubscriptionStats, which returnssubscriptionBalanceplus 5-hour / 7-day Code quota ratios. CodexBar was silently dropping the monthly enrichment and had no model field for the subscription 7-day Code quota.Validation
git diff --checkswiftc -parseon the touched source filesswift test --filter KimiProviderTestscould not run locally because this machine's Command Line Tools install fails before compilation withxcrun: error: unable to lookup item 'PlatformPath' from command line tools installation.