Skip to content

Fix Tahoe no-window menu bar recovery#1954

Merged
steipete merged 1 commit into
mainfrom
codex/fix-tahoe-no-proxy-status-item
Jul 6, 2026
Merged

Fix Tahoe no-window menu bar recovery#1954
steipete merged 1 commit into
mainfrom
codex/fix-tahoe-no-proxy-status-item

Conversation

@steipete

@steipete steipete commented Jul 6, 2026

Copy link
Copy Markdown
Owner

Summary

  • preserve the app's intended visible status-item names independently of Tahoe's rejected AppKit state
  • detect the startup-only no-window failure only when app intent and the persisted enabled visibility default agree
  • ignore user-hidden items, menu-manager hiding, stale hidden window records, and pre-Tahoe systems
  • add focused startup, defaults, and split/merged lifecycle regression coverage

Validation

  • swift test --filter MenuBarVisibilityWatcherTests (36 tests)
  • swift test --filter StatusItemControllerSplitLifecycleTests (24 tests)
  • make check
  • make test (48/48 shards)
  • autoreview: clean after fixing stale hidden-window handling

Tahoe 26.5 bundle proof was stopped when the signed test app unexpectedly requested a Keychain password despite all providers being disabled. No credentials were entered and no private Control Center preferences were changed.

Closes #1945

@steipete steipete merged commit 4484fad into main Jul 6, 2026
5 of 9 checks passed
@steipete steipete deleted the codex/fix-tahoe-no-proxy-status-item branch July 6, 2026 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant