MiniMax: quota utilization history and reset-time display#1983
MiniMax: quota utilization history and reset-time display#1983Yuxin-Qiao wants to merge 4 commits into
Conversation
Add token_plan_credit enrichment for cookie-backed refreshes, MiniMax Agent desktop cookie import, API-token web enrichment resolver, and menu credit display. Co-authored-by: Cursor <cursoragent@cursor.com>
Record Session and Weekly quota samples, show subscription utilization charts, and prefer the nearest MiniMax reset window in the menu bar. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Codex review: needs changes before merge. Reviewed July 8, 2026, 12:31 AM ET / 04:31 UTC. Summary Reproducibility: yes. for the review findings from source inspection: current main has a percent-mode merged Codex countdown scheduling test, and the PR now returns before that path can schedule. The Codex credits hint regression is also source-reproducible through Model.make with a Codex projection, nil credits, and nil creditsError. Review metrics: 2 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Maintainer decision needed
Security Review findings
Review detailsBest possible solution: Preserve existing Codex menu-bar and card behavior, keep the MiniMax credential-boundary work aligned with #1981, then land the quota-history/reset UI with focused regression coverage. Do we have a high-confidence way to reproduce the issue? Yes for the review findings from source inspection: current main has a percent-mode merged Codex countdown scheduling test, and the PR now returns before that path can schedule. The Codex credits hint regression is also source-reproducible through Model.make with a Codex projection, nil credits, and nil creditsError. Is this the best way to solve the issue? No for the current head: the MiniMax feature direction is useful, but the patch should preserve existing Codex projection behavior and keep the credential-boundary stack aligned with the prerequisite PR. The safer path is a small repair on this branch plus maintainer review of the auth surface. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against aa401f1d8b74. Label changesLabel changes:
Label justifications:
Evidence reviewedAcceptance criteria:
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
Review history (1 earlier review cycle)
|
Move menuBarResetTimeWindow into the countdown refresh extension. Co-authored-by: Cursor <cursoragent@cursor.com>
Restore now-parameter signatures, debug button titles, and Codex combined-lane selection while keeping MiniMax-specific reset-time routing. Co-authored-by: Cursor <cursoragent@cursor.com>
Summary
Split from #1821 (PR C). Merge after #1981 (can land in parallel with the dashboard PR).
MenuBarMetricWindowResolvernearest-reset helperTest plan
swift buildswift test --filter UsageStorePlanUtilizationswift test --filter MenuBarResetTimeDisplayMerge order
Made with Cursor