Stop OpenRouter from replacing the menu-bar meter with its logo#854
Open
willytop8 wants to merge 1 commit intosteipete:mainfrom
Open
Stop OpenRouter from replacing the menu-bar meter with its logo#854willytop8 wants to merge 1 commit intosteipete:mainfrom
willytop8 wants to merge 1 commit intosteipete:mainfrom
Conversation
OpenRouter has a brand logo, but the logo suppresses usage information that is more useful in the menu bar. This change makes OpenRouter always render its usage meter (the same capsule bar all other providers use) regardless of whether a brand image is available. - Removes the logo-fallback branch from applyIcon(for:phase:) for OpenRouter; the meter path is now unconditional - Adds pixel-level tests confirming the meter renders (not the logo) both when key data is available with no configured limit and when key data has not been fetched yet Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
willytop8
force-pushed
the
wr/openrouter-no-logo-menu-icon
branch
from
af76794 to
dfcee77
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When OpenRouter has no configured key limit, the existing code fell through to a brand-logo fallback — showing the OpenRouter logo in the menu bar instead of a usage meter, which hides useful information in favor of branding.
Removes the logo-fallback branch for OpenRouter so the meter always renders, same as every other provider.
brandImageWithStatusOverlayis kept; it still has callers in the test suite.Also adds two pixel-level tests using
NSBitmapImageRep.colorAtto confirm a meter renders (not a logo). A logo would be nearly fully opaque; an unfilled meter track has alpha ≈ 0.28. One test covers the no-key-limit case, one covers key data not yet fetched.