Skip to content

Add command code support#857

Open
sixhobbits wants to merge 2 commits intosteipete:mainfrom
sixhobbits:add-command-code-support
Open

Add command code support#857
sixhobbits wants to merge 2 commits intosteipete:mainfrom
sixhobbits:add-command-code-support

Conversation

@sixhobbits
Copy link
Copy Markdown

Might be slop because I'm not a macos dev and I don't have XCode so my agent had to do a bunch of workarounds to build this locally and test it

But it works for me

CleanShot 2026-05-07 at 12 22 12@2x image image

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7fbb353304

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines +50 to +51
return CommandCodeCookieOverride(
name: self.supportedSessionCookieNames[0],
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Use the secure cookie name for bare tokens

When a bare session token is provided, this now picks supportedSessionCookieNames[0], which is __Host-better-auth.session_token; the added CommandCodeUsageFetcherTests.cookie header accepts bare token and uses secure name expects __Secure-better-auth.session_token, so the new test suite fails and bare-token manual setup will send the wrong cookie name for the documented production variant. Choose the intended production cookie name explicitly instead of depending on the array order.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant