fix: update docker container running alert (#392)

* fix: update docker container running alert

* chore: add tests for docker utils

* chore: clippy

* chore: remove unnecessary tests

* fix: ensure correct network config on deploy

Author: zachfedor

crates/stellar-scaffold-cli/src/commands/build/clients.rs

@@ -756,7 +756,7 @@ export default new Client.Client({{
         let deploy_cmd = cli::contract::deploy::wasm::Cmd::parse_arg_vec(&deploy_arg_refs)?;
         let contract_id = deploy_cmd
             .execute(
-                &deploy_cmd.config,
+                &self.config(),
                 self.global_args.quiet,
                 self.global_args.no_cache,
             )

crates/stellar-scaffold-cli/src/commands/build/docker.rs

@@ -6,7 +6,7 @@ pub async fn start_local_stellar() -> Result<(), Box<dyn Error>> {
         .run(&stellar_cli::commands::global::Args::default())
         .await;
     if let Err(e) = result {
-        if e.to_string().contains("already in use")
+        if e.to_string().contains("already running")
             || e.to_string().contains("port is already allocated")
         {
             eprintln!("Container is already running, proceeding to health check...");

crates/stellar-scaffold-cli/tests/it/build_clients/docker.rs

@@ -0,0 +1,39 @@
+use stellar_cli::{CommandParser, commands as cli};
+
+/// Make sure that `start_local_stellar` is idempotent. It shouldn't fail if container
+/// is already running, it should skip startup logic and proceed to health checks.
+#[tokio::test]
+async fn start_local_stellar_is_idempotent() {
+    // Test harness already sets up network, so this is _second_ call
+    let result = stellar_scaffold_cli::commands::build::docker::start_local_stellar().await;
+    assert!(
+        result.is_ok(),
+        "start_local_stellar should succeed when the container is already running, got: {result:?}"
+    );
+}
+
+/// Directly invoke the underlying `container start` CLI command and assert that
+/// the error message still contains at least one of the substrings we rely on
+/// to detect an already-running container.
+///
+/// See: <https://github.com/theahaco/scaffold-stellar/pull/392>
+#[tokio::test]
+async fn container_start_error_contains_expected_substring() {
+    let cmd = cli::container::StartCmd::parse_arg_vec(&["local"])
+        .expect("failed to parse container start command");
+
+    let result = cmd
+        .run(&stellar_cli::commands::global::Args::default())
+        .await;
+
+    // Verify that the error matches what we're expecting
+    if let Err(e) = result {
+        let msg = e.to_string();
+        assert!(
+            msg.contains("already running") || msg.contains("port is already allocated"),
+            "Container start error message changed! \
+             Expected it to contain \"already running\" or \"port is already allocated\", \
+             but got: \"{msg}\""
+        );
+    }
+}

crates/stellar-scaffold-cli/tests/it/build_clients/mod.rs

@@ -1,2 +1,3 @@
 mod accounts;
 mod contracts;
+mod docker;