Skip to content

fix: update docker container running alert#392

Merged
zachfedor merged 6 commits into
mainfrom
fix/container-running-message
Mar 2, 2026
Merged

fix: update docker container running alert#392
zachfedor merged 6 commits into
mainfrom
fix/container-running-message

Conversation

@zachfedor

@zachfedor zachfedor commented Feb 19, 2026

Copy link
Copy Markdown
Contributor

Match an update to the Stellar-CLI from this PR that broke how we determined if a container was already running. Currently, scaffold build will error out if the container is already running because the string mismatch, or logic assumes there was an error with it instead of continuing on with the health check.

@willemneal

Copy link
Copy Markdown
Contributor

@copilot Can you fix the clippy errors

Copilot AI commented Feb 19, 2026

Copy link
Copy Markdown
Contributor

@willemneal I've opened a new pull request, #393, to work on those changes. Once the pull request is ready, I'll request review from you.

@zachfedor

Copy link
Copy Markdown
Contributor Author

@willemneal, it took me a while to hunt this down, but I think I found a problem from your PR that updated scaffold to use stellar-cli v25, specifically these lines. I think the deploy_contract function was using the wrong network configuration, and since that didn't include --rpc-url or --network-passphrase, the parsed config had no network info which was causing get_remote_wasm_from_hash to fail with "Contract Code not found" on my system when trying to build clients.

No need to look now, I can explain better tomorrow in our weekly update.

@zachfedor zachfedor merged commit bb58c4d into main Mar 2, 2026
7 checks passed
@zachfedor zachfedor deleted the fix/container-running-message branch March 2, 2026 01:03
@aha-release-plz aha-release-plz Bot mentioned this pull request Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants