Skip to content

feat: add dtslint to repo#1094

Open
ShantelPeters wants to merge 5 commits intostellar:masterfrom
ShantelPeters:add-dtslint
Open

feat: add dtslint to repo#1094
ShantelPeters wants to merge 5 commits intostellar:masterfrom
ShantelPeters:add-dtslint

Conversation

@ShantelPeters
Copy link
Copy Markdown

resolves #649

@ShantelPeters
Copy link
Copy Markdown
Author

@chadoh @BlaineHeffron and @Shaptic
Please kindly review 🙏🏼

Comment thread config/.eslintrc.js
// ERROR
'no-unused-expressions': [2, { allowTaggedTemplates: true }]
}
};
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC there's something weird about .eslintrc.js existing in the root directory and being picked up by subprograms, bundlers, etc. so I'd prefer if we kept it in there instead of moving it like this. I would say all of config/* needs to get out of that folder (it was a mistake for me to try to consolidate in the first place) but that's a separate issue entirely.

@ShantelPeters
Copy link
Copy Markdown
Author

Please kindly review @Shaptic

@ShantelPeters
Copy link
Copy Markdown
Author

@Shaptic
@chadoh kindly review requested changes

@ShantelPeters
Copy link
Copy Markdown
Author

gm @Shaptic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog (Not Ready)

Development

Successfully merging this pull request may close these issues.

Developer feature request: Add dtslint to the toolkit

2 participants