Adding missing types to account_response#1173
Merged
Merged
Conversation
|
Pls sers review this |
Shaptic
approved these changes
May 14, 2025
Contributor
Shaptic
left a comment
Shaptic
left a comment
There was a problem hiding this comment.
Thank you for the catch and fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now we just ts-ignore to be able to get the num_sponsered from the account_response, because the type says the key is not available when in reality it is there.
Wanted to do a permenant fix because it's not in line with the Account Response type from the horizon api type