Deprecate stellar --list in favor of stellar plugin ls. (#2250)

Author: fnando

FULL_HELP_DOCS.md

@@ -68,7 +68,7 @@ Anything after the `--` double dash (the "slop") is parsed as arguments to the c
 - `-q`, `--quiet` — Do not write logs to stderr including `INFO`
 - `-v`, `--verbose` — Log DEBUG events
 - `--very-verbose` [alias: `vv`] — Log DEBUG and TRACE events
-- `--list` — List installed plugins. E.g. `stellar-hello`
+- `--list` — ⚠️ Deprecated, use `stellar plugin ls`. List installed plugins. E.g. `stellar-hello`
 - `--no-cache` — Do not cache your simulations and transactions
 
 ## `stellar contract`

cmd/crates/soroban-test/tests/it/plugin.rs

@@ -34,10 +34,11 @@ fn stellar_bye() {
 
 #[test]
 fn list() {
-    // Call `soroban --list` with the PATH variable set to include the target/bin directory
+    // Call `stellar plugin ls` with the PATH variable set to include the target/bin directory
     assert_cmd::Command::cargo_bin("stellar")
         .unwrap_or_else(|_| assert_cmd::Command::new("stellar"))
-        .arg("--list")
+        .arg("plugin")
+        .arg("ls")
         .env("PATH", get_paths())
         .assert()
         .stdout(predicates::str::contains("hello"))

cmd/soroban-cli/src/commands/global.rs

@@ -39,7 +39,7 @@ pub struct Args {
     #[arg(long, visible_alias = "vv", global = true, help_heading = HEADING_GLOBAL)]
     pub very_verbose: bool,
 
-    /// List installed plugins. E.g. `stellar-hello`
+    /// ⚠️ Deprecated, use `stellar plugin ls`. List installed plugins. E.g. `stellar-hello`
     #[arg(long)]
     pub list: bool,
 

cmd/soroban-cli/src/commands/mod.rs

@@ -87,6 +87,8 @@ impl Root {
     pub fn new() -> Result<Self, Error> {
         Self::try_parse().map_err(|e| {
             if std::env::args().any(|s| s == "--list") {
+                let print = Print::new(std::env::args().any(|s| s == "--quiet" || s == "-q"));
+                deprecate_message(print, "--list", "Use `stellar plugin ls` instead.");
                 let _ = plugin::ls::Cmd.run();
                 std::process::exit(0);
             }