Remove deprecated --global.

Author: fnando

FULL_HELP_DOCS.md

@@ -272,10 +272,7 @@ impl TestEnv {
                 network: None,
             },
             source_account: account.parse().unwrap(),
-            locator: config::locator::Args {
-                global: false,
-                config_dir,
-            },
+            locator: config::locator::Args { config_dir },
             sign_with: config::sign_with::Args {
                 sign_with_key: None,
                 hd_path: None,

cmd/crates/soroban-test/src/lib.rs

@@ -137,7 +137,6 @@ mod tests {
     fn set_up_test() -> (super::locator::Args, super::Cmd) {
         let temp_dir = tempfile::tempdir().unwrap();
         let locator = super::locator::Args {
-            global: false,
             config_dir: Some(temp_dir.path().to_path_buf()),
         };
 

cmd/soroban-cli/src/commands/keys/generate.rs

@@ -150,7 +150,6 @@ mod tests {
     fn setup_locator() -> locator::Args {
         let temp_dir = tempfile::tempdir().unwrap();
         locator::Args {
-            global: false,
             config_dir: Some(temp_dir.path().to_path_buf()),
         }
     }

cmd/soroban-cli/src/commands/message/sign.rs

@@ -165,7 +165,6 @@ mod tests {
     fn setup_locator() -> locator::Args {
         let temp_dir = tempfile::tempdir().unwrap();
         locator::Args {
-            global: false,
             config_dir: Some(temp_dir.path().to_path_buf()),
         }
     }

cmd/soroban-cli/src/commands/message/verify.rs

@@ -2,7 +2,7 @@ use std::str::FromStr;
 
 use clap::{error::ErrorKind, CommandFactory, FromArgMatches, Parser};
 
-use crate::{config, print::Print, utils::deprecate_message};
+use crate::config;
 
 pub mod cache;
 pub mod cfg;
@@ -104,16 +104,6 @@ impl Root {
     }
 
     pub async fn run(&mut self) -> Result<(), Error> {
-        let print = Print::new(self.global_args.quiet);
-
-        if self.global_args.locator.global {
-            deprecate_message(
-                print,
-                "--global",
-                "Global configuration is now the default behavior.",
-            );
-        }
-
         match &mut self.cmd {
             Cmd::Completion(completion) => completion.run(),
             Cmd::Plugin(plugin) => plugin.run(&self.global_args).await?,

cmd/soroban-cli/src/commands/mod.rs

@@ -45,7 +45,7 @@ impl Cmd {
                     format!("\n{}", lines.join("\n"))
                 };
 
-                (!self.config_locator.global || location == "Global").then(|| {
+                (location == "Global").then(|| {
                     Some(format!(
                         "Name: {name}\nRPC url: {rpc_url}\nRPC headers:{headers}\nNetwork passphrase: {passphrase}",
                         rpc_url = network.rpc_url,

cmd/soroban-cli/src/commands/network/ls.rs

@@ -110,10 +110,6 @@ pub enum Error {
 #[derive(Debug, clap::Args, Default, Clone)]
 #[group(skip)]
 pub struct Args {
-    /// ⚠️ Deprecated: global config is always on
-    #[arg(long, global = true, help_heading = HEADING_GLOBAL)]
-    pub global: bool,
-
     /// Location of config directory. By default, it uses `$XDG_CONFIG_HOME/stellar` if set, falling back to `~/.config/stellar` otherwise.
     /// Contains configuration files, aliases, and other persistent settings.
     #[arg(long, global = true, help_heading = HEADING_GLOBAL)]
@@ -159,11 +155,6 @@ impl Location {
 
 impl Args {
     pub fn config_dir(&self) -> Result<PathBuf, Error> {
-        if self.global {
-            let print = Print::new(false);
-            print.warnln("Flag --global is deprecated: global config is always used");
-        }
-
         self.global_config_path()
     }