Merge branch 'main' into feat/local-ts-boilerplate

Author: leighmcculloch

.cargo/config.toml

@@ -2,7 +2,6 @@
 
 [alias] # command aliases
 f = "fmt"
-md-gen = "run --bin doc-gen"
 s = "run --quiet --"
 # b = "build"
 # c = "check"

.github/actions/build-and-test/action.yml

@@ -30,6 +30,12 @@ runs:
     - if: runner.os == 'Linux'
       run: sudo apt-get update && sudo apt-get -y install gcc-aarch64-linux-gnu g++-aarch64-linux-gnu libudev-dev libdbus-1-dev
       shell: bash
+    - run: make build-test-wasms
+      shell: bash
+      env:
+        CARGO_TARGET_AARCH64_UNKNOWN_LINUX_GNU_LINKER: aarch64-linux-gnu-gcc
+        CARGO_BUILD_TARGET: ${{ inputs.target }}
+        CI_TESTS: true
     - run: cargo clippy --all-targets --target ${{ inputs.target }}
       shell: bash
     - run: make test

.github/copilot-instructions.md

@@ -9,7 +9,7 @@ Stellar CLI is a Rust-based command-line tool for interacting with the Stellar n
 ### Bootstrap and Build
 
 - Install system dependencies: `sudo apt-get update && sudo apt-get install -y libudev-dev libdbus-1-dev build-essential`
-- Install Rust toolchain: `rustup update` (Rust 1.89.0+ required)
+- Install Rust toolchain: `rustup update` (Rust 1.92.0+ required)
 - Add WebAssembly target: `rustup target add wasm32v1-none`
 - Build main CLI: `cargo build --bin stellar` -- takes 45 seconds. NEVER CANCEL.
 - Install CLI: `make install` -- takes 3 minutes with potential network timeouts. NEVER CANCEL. Set timeout to 10+ minutes.
@@ -24,6 +24,7 @@ Stellar CLI is a Rust-based command-line tool for interacting with the Stellar n
 
 - Test main soroban-cli library: `cargo test --package soroban-cli --lib` -- takes 52 seconds. NEVER CANCEL.
 - Test individual crates: `cargo test --package <crate-name>` -- typically takes 40 seconds per crate.
+- Test soroban-test integration tests: `cargo test --features it --test it -- integration` -- tests the commands of the cli and is where the bulk of the tests live for this repository. All new commands and changes to commands should include updates or additions to tests in soroban-test.
 - **WARNING**: Full test suite via `make test` requires building WebAssembly test fixtures and consumes significant memory and disk space. It may fail with "No space left on device" in constrained environments.
 
 ### CLI Usage and Validation
@@ -112,7 +113,6 @@ stellar keys address test      # Test key operations
 The project uses GitHub Actions with workflows in `.github/workflows/`:
 
 - `rust.yml`: Main CI pipeline with formatting, linting, building, and testing
-- `e2e.yml`: End-to-end system tests
 - `binaries.yml`: Multi-platform binary builds
 
 Always run `make fmt` and `make check` locally before pushing to ensure CI passes.

.github/workflows/action.yml

@@ -0,0 +1,23 @@
+---
+name: Action
+
+on:
+  pull_request:
+
+concurrency:
+  group:
+    ${{ github.workflow }}-${{ github.ref_protected == 'true' && github.sha ||
+    github.ref }}-{{ github.event_name	}}
+  cancel-in-progress: true
+
+jobs:
+  action:
+    strategy:
+      matrix:
+        image: [macos-15, macos-15-intel, ubuntu-latest, windows-latest]
+    runs-on: ${{ matrix.image }}
+
+    steps:
+      - uses: stellar/stellar-cli@main
+        with:
+          version: v23.1.4

.github/workflows/binaries.yml

@@ -35,7 +35,7 @@ jobs:
             target: aarch64-unknown-linux-gnu
     runs-on: ${{ matrix.sys.os }}
     steps:
-      - uses: actions/checkout@v5
+      - uses: actions/checkout@v6
       - uses: ./.github/actions/build-binary
         with:
           target: ${{ matrix.sys.target }}
@@ -53,13 +53,13 @@ jobs:
           - name: stellar-cli
             binary: stellar
         sys:
-          - os: macos-14
+          - os: macos-15
             target: aarch64-apple-darwin
-          - os: macos-13
+          - os: macos-15-intel
             target: x86_64-apple-darwin
     runs-on: ${{ matrix.sys.os }}
     steps:
-      - uses: actions/checkout@v5
+      - uses: actions/checkout@v6
       - uses: ./.github/actions/build-binary
         with:
           target: ${{ matrix.sys.target }}
@@ -82,19 +82,82 @@ jobs:
             ext: .exe
     runs-on: ${{ matrix.sys.os }}
     steps:
-      - uses: actions/checkout@v5
+      - uses: actions/checkout@v6
       - uses: ./.github/actions/build-binary
         with:
           target: ${{ matrix.sys.target }}
           crate-name: ${{ matrix.crate.name }}
           binary-name: ${{ matrix.crate.binary }}
           binary-ext: ${{ matrix.sys.ext }}
 
+  deb:
+    needs: [build]
+    strategy:
+      fail-fast: false
+      matrix:
+        include:
+          - target: x86_64-unknown-linux-gnu
+            arch: amd64
+            os: ubuntu-22.04
+          - target: aarch64-unknown-linux-gnu
+            arch: arm64
+            os: ubuntu-22.04-arm
+    runs-on: ${{ matrix.os }}
+    steps:
+      - uses: actions/checkout@v6
+
+      - name: Setup vars
+        run: |
+          version="$(cargo metadata --format-version 1 --no-deps | jq -r '.packages[] | select(.name == "stellar-cli") | .version')"
+          echo "VERSION=${version}" >> $GITHUB_ENV
+          echo "ARTIFACT_NAME=stellar-cli-${version}-${{ matrix.target }}.tar.gz" >> $GITHUB_ENV
+          echo "DEB_NAME=stellar-cli_${version}_${{ matrix.arch }}.deb" >> $GITHUB_ENV
+          echo "DEB_PKG_DIR=stellar-cli_${version}_${{ matrix.arch }}" >> $GITHUB_ENV
+
+      - name: Download Artifact
+        uses: actions/download-artifact@v8.0.1
+        with:
+          name: ${{ env.ARTIFACT_NAME }}
+
+      - name: Build deb
+        run: |
+          mkdir -p ${{ env.DEB_PKG_DIR }}/usr/bin
+          mkdir -p ${{ env.DEB_PKG_DIR }}/DEBIAN
+          tar xzvf ${{ env.ARTIFACT_NAME }} -C ${{ env.DEB_PKG_DIR }}/usr/bin
+
+          cat > ${{ env.DEB_PKG_DIR }}/DEBIAN/control <<EOF
+          Package: stellar-cli
+          Version: ${{ env.VERSION }}
+          Section: utils
+          Priority: optional
+          Architecture: ${{ matrix.arch }}
+          Depends: libc6, libdbus-1-3, libudev1, libssl3
+          Maintainer: Stellar Development Foundation <info@stellar.org>
+          Homepage: https://github.com/stellar/stellar-cli
+          Description: Stellar CLI
+           Command-line interface for interacting with the Stellar network.
+          EOF
+
+          dpkg-deb --root-owner-group --build ${{ env.DEB_PKG_DIR }}
+
+      - name: Validate deb
+        run: |
+          dpkg-deb --info ${{ env.DEB_NAME }}
+          dpkg-deb --contents ${{ env.DEB_NAME }}
+          sudo dpkg -i ${{ env.DEB_NAME }}
+          stellar --version
+
+      - name: Upload Artifact
+        uses: ./.github/actions/artifact-upload
+        with:
+          name: ${{ env.DEB_NAME }}
+          path: ${{ env.DEB_NAME }}
+
   installer:
     needs: [build, build-macos, build-windows]
     runs-on: windows-latest
     steps:
-      - uses: actions/checkout@v5
+      - uses: actions/checkout@v6
 
       - name: Setup vars
         run: |
@@ -104,25 +167,50 @@ jobs:
           echo "STELLAR_CLI_INSTALLER_BASENAME=${installer_basename}" >> $GITHUB_ENV
           echo "STELLAR_CLI_INSTALLER=${installer_basename}.exe" >> $GITHUB_ENV
           echo "ARTIFACT_NAME=stellar-cli-${version}-x86_64-pc-windows-msvc.tar.gz" >> $GITHUB_ENV
+          echo "SM_CLIENT_CERT_FILE=D:\\sm_client_cert.p12" >> "$GITHUB_ENV"
 
       - name: Download Artifact
-        uses: actions/download-artifact@v5
+        uses: actions/download-artifact@v8.0.1
         with:
           name: ${{ env.ARTIFACT_NAME }}
+
       - name: Uncompress Artifact
         run: tar xvf ${{ env.ARTIFACT_NAME }}
+
       - shell: powershell
-        run: winget install --id JRSoftware.InnoSetup --scope machine --silent --accept-package-agreements --accept-source-agreements
+        run: winget install --id JRSoftware.InnoSetup --scope machine --silent --accept-package-agreements --accept-source-agreements --force
+
       - shell: powershell
         run: |
           $innoPath = "C:\Program Files (x86)\Inno Setup 6"
           echo $innoPath | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append
+
       - name: Build Installer
         shell: powershell
         run: |
           $Env:STELLAR_CLI_VERSION = "${{ env.VERSION }}"
           ISCC.exe installer.iss
           mv Output/stellar-installer.exe ${{ env.STELLAR_CLI_INSTALLER }}
+
+      - name: Setup SM_CLIENT_CERT_FILE
+        run: |
+          echo "${{ secrets.SM_CLIENT_CERT_FILE_B64 }}" | base64 --decode > /d/sm_client_cert.p12
+        shell: bash
+
+      - name: Setup Software Trust Manager
+        env:
+          SM_HOST: https://clientauth.one.digicert.com
+          SM_API_KEY: ${{ secrets.SM_API_KEY }}
+          SM_CLIENT_CERT_PASSWORD: ${{ secrets.SM_CLIENT_CERT_PASSWORD }}
+        if:
+          github.event_name == 'release' || startsWith(github.ref, 'refs/heads/release/') || startsWith(github.head_ref, 'release/')
+        id: stm-setup
+        uses: digicert/code-signing-software-trust-action@v1.2.1
+        with:
+          simple-signing-mode: true
+          keypair-alias: key_1412258126
+          input: ${{ env.STELLAR_CLI_INSTALLER }}
+
       - name: Upload Artifact
         uses: ./.github/actions/artifact-upload
         with:

.github/workflows/bindings-ts.yml

@@ -16,22 +16,22 @@ jobs:
           - ubuntu-latest-8-cores
           # ARM
           - ubuntu-jammy-8-cores-arm64
-          # Intel
-          - macos-13
+          # Apple Intel (this runner has better support to nested virtualization)
+          - macos-15-large
         exclude:
-          # Only run Linux x64 tests on pull request to save some time
-          - sys:
-              ${{ github.event_name != 'push' && 'ubuntu-jammy-8-cores-arm64' }}
-          - sys: ${{ github.event_name != 'push' && 'macos-13' }}
+          # Only run Linux x64 on non-release PRs to save CI minutes
+          - sys: ${{ github.event_name != 'push' && !startsWith(github.ref_name, 'release/') && 'ubuntu-jammy-8-cores-arm64' }}
+          - sys: ${{ github.event_name != 'push' && !startsWith(github.ref_name, 'release/') && 'macos-15-large' }}
     runs-on: ${{ matrix.sys }}
     steps:
       - uses: stellar/quickstart@main
         with:
           tag: testing
-      - uses: actions/setup-node@v5
+          protocol_version: 26
+      - uses: actions/setup-node@v6
         with:
           node-version: "20.x"
-      - uses: actions/checkout@v5
+      - uses: actions/checkout@v6
       - uses: stellar/actions/rust-cache@main
       - run: rustup update
       - name: install optional dependencies (Linux only)