Refactoring binaries workflow (#1956)

* Refactoring binaries workflow

* Remove json-schema job

* Move back binary attestation

Author: Gleb

.github/actions/artifact-upload/action.yml

@@ -0,0 +1,39 @@
+name: 'Artifact upload'
+description: 'Uploads artifact to release'
+inputs:
+  name:
+    description: "Name of the artifact to upload"
+    required: true
+  path:
+    description: "Path of the artifact to upload"
+    required: true
+runs:
+  using: "composite"
+  steps:
+    - name: Upload Artifact
+      uses: actions/upload-artifact@v4
+      with:
+        name: ${{ inputs.name }}
+        path: ${{ inputs.path }}
+
+    - name: Build provenance for attestation (release only)
+      if: github.event_name == 'release'
+      uses: actions/attest-build-provenance@v2
+      with:
+        subject-path: ${{ inputs.path }}
+
+    - name: Upload to Release (release only)
+      if: github.event_name == 'release'
+      uses: actions/github-script@v7
+      with:
+        script: |
+          const fs = require('fs');
+          await github.rest.repos.uploadReleaseAsset({
+            owner: context.repo.owner,
+            repo: context.repo.repo,
+            release_id: ${{ github.event.release.id }},
+            name: '${{ inputs.name }}',
+            data: fs.readFileSync('${{ inputs.path }}'),
+          });
+    
+

.github/workflows/binaries.yml

@@ -57,94 +57,25 @@ jobs:
     - name: Build
       run: |
         cargo build --package ${{ matrix.crate.name }} --features opt --release --target ${{ matrix.sys.target }}
-
-    - name: Build provenance for attestation (release only)
+    - name: Build provenance for binary attestation (release only)
       if: github.event_name == 'release'
       uses: actions/attest-build-provenance@v2
       with:
         subject-path: target/${{ matrix.sys.target }}/release/${{ matrix.crate.binary }}${{ matrix.sys.ext }}
-
     - name: Compress
       run: |
           cd target/${{ matrix.sys.target }}/release
           tar czvf $NAME.tar.gz ${{ matrix.crate.binary }}${{ matrix.sys.ext }}
 
     - name: Upload to Artifacts
-      uses: actions/upload-artifact@v4
+      uses: ./.github/actions/artifact-upload
       with:
         name: ${{ env.NAME }}.tar.gz
         path: 'target/${{ matrix.sys.target }}/release/${{ env.NAME }}.tar.gz'
 
-    - name: Upload to Release (release only)
-      if: github.event_name == 'release'
-      uses: actions/github-script@v7
-      with:
-        script: |
-          const fs = require('fs');
-          await github.rest.repos.uploadReleaseAsset({
-            owner: context.repo.owner,
-            repo: context.repo.repo,
-            release_id: ${{ github.event.release.id }},
-            name: '${{ env.NAME }}.tar.gz',
-            data: fs.readFileSync('target/${{ matrix.sys.target }}/release/${{ env.NAME }}.tar.gz'),
-          });
-
-  json-schema:
-    needs: build
-    runs-on: ubuntu-22.04
-
-    steps:
-      - run: sudo apt-get update && sudo apt-get -y install libudev-dev libdbus-1-dev
-      - uses: actions/checkout@v4
-
-      - name: Setup vars
-        run: |
-          version="$(cargo metadata --format-version 1 --no-deps | jq -r '.packages[] | select(.name == "stellar-cli") | .version')"
-          echo "JSON_SCHEMA_NAME=stellar-xdr-${version}.json" >> $GITHUB_ENV
-          echo "ARTIFACT_NAME=stellar-cli-${version}-x86_64-unknown-linux-gnu.tar.gz" >> $GITHUB_ENV
-
-      - name: Download Artifact
-        uses: actions/download-artifact@v4
-        with:
-          name: ${{ env.ARTIFACT_NAME }}
-
-      - name: Uncompress Artifact
-        run: tar xvf ${{ env.ARTIFACT_NAME }}
-
-      - name: Export JSON Schema
-        run: |
-          ./stellar xdr types schema --type TransactionEnvelope > ${{ env.JSON_SCHEMA_NAME }}
-
-      - name: Upload Artifact
-        uses: actions/upload-artifact@v4
-        with:
-          name: ${{ env.JSON_SCHEMA_NAME }}
-          path: ${{ env.JSON_SCHEMA_NAME }}
-
-      - name: Build provenance for attestation (release only)
-        if: github.event_name == 'release'
-        uses: actions/attest-build-provenance@v2
-        with:
-          subject-path: ${{ env.JSON_SCHEMA_NAME }}
-
-      - name: Upload to Release (release only)
-        if: github.event_name == 'release'
-        uses: actions/github-script@v7
-        with:
-          script: |
-            const fs = require('fs');
-            await github.rest.repos.uploadReleaseAsset({
-              owner: context.repo.owner,
-              repo: context.repo.repo,
-              release_id: ${{ github.event.release.id }},
-              name: '${{ env.JSON_SCHEMA_NAME }}',
-              data: fs.readFileSync('${{ env.JSON_SCHEMA_NAME }}'),
-            });
-
   installer:
     needs: build
     runs-on: windows-latest
-
     steps:
       - uses: actions/checkout@v4
 
@@ -161,41 +92,17 @@ jobs:
         uses: actions/download-artifact@v4
         with:
           name: ${{ env.ARTIFACT_NAME }}
-
       - name: Uncompress Artifact
         run: tar xvf ${{ env.ARTIFACT_NAME }}
-
       - name: Build Installer
         shell: powershell
         run: |
           $Env:Path += ";C:\Users\$Env:UserName\AppData\Local\Programs\Inno Setup 6"
           $Env:STELLAR_CLI_VERSION = "${{ env.VERSION }}"
           ISCC.exe installer.iss
           mv Output/stellar-installer.exe ${{ env.STELLAR_CLI_INSTALLER }}
-
       - name: Upload Artifact
-        uses: actions/upload-artifact@v4
+        uses: ./.github/actions/artifact-upload
         with:
           name: ${{ env.STELLAR_CLI_INSTALLER }}
           path: ${{ env.STELLAR_CLI_INSTALLER }}
-
-      - name: Build provenance for attestation (release only)
-        if: github.event_name == 'release'
-        uses: actions/attest-build-provenance@v2
-        with:
-          subject-path: ${{ env.STELLAR_CLI_INSTALLER }}
-
-      - name: Upload to Release (release only)
-        if: github.event_name == 'release'
-        uses: actions/github-script@v7
-        with:
-          script: |
-            const fs = require('fs');
-            await github.rest.repos.uploadReleaseAsset({
-              owner: context.repo.owner,
-              repo: context.repo.repo,
-              release_id: ${{ github.event.release.id }},
-              name: '${{ env.STELLAR_CLI_INSTALLER }}',
-              data: fs.readFileSync('${{ env.STELLAR_CLI_INSTALLER }}'),
-            });
-