Merge branch 'main' into janewang-patch-cookbook

Author: janewang

.cargo-husky/hooks/pre-commit

@@ -2,5 +2,8 @@
 
 set -ex
 
-cargo fmt --check || (cargo fmt && exit 1)
-make generate-full-help-doc
+make docs > /dev/null
+make fmt > /dev/null
+
+set +x
+git diff --exit-code > /dev/null || (echo "\nERROR: Staged files were modified by hooks. Please review and stage the changes." && exit 1)

.cargo-husky/hooks/pre-push

@@ -10,4 +10,4 @@ cargo clippy --all -- -Dwarnings
 
 cargo build
 cargo test --all || (echo "might need to rebuild make build-snapshot" && exit 1)
-make generate-full-help-doc
+make docs

.github/copilot-instructions.md

@@ -7,23 +7,27 @@
 Stellar CLI is a Rust-based command-line tool for interacting with the Stellar network. It's organized as a Cargo workspace with multiple crates and uses both Cargo and Make for build automation.
 
 ### Bootstrap and Build
+
 - Install system dependencies: `sudo apt-get update && sudo apt-get install -y libudev-dev libdbus-1-dev build-essential`
 - Install Rust toolchain: `rustup update` (Rust 1.89.0+ required)
 - Add WebAssembly target: `rustup target add wasm32v1-none`
 - Build main CLI: `cargo build --bin stellar` -- takes 45 seconds. NEVER CANCEL.
 - Install CLI: `make install` -- takes 3 minutes with potential network timeouts. NEVER CANCEL. Set timeout to 10+ minutes.
 
 ### Core Development Commands
+
 - Format code: `make fmt` -- takes 2 seconds
 - Run linting: `make check` -- takes 7 minutes. NEVER CANCEL. Set timeout to 15+ minutes.
 - Build main CLI only: `cargo build --bin stellar` -- takes 45 seconds. Use this for quick iterations.
 
 ### Testing
+
 - Test main soroban-cli library: `cargo test --package soroban-cli --lib` -- takes 52 seconds. NEVER CANCEL.
 - Test individual crates: `cargo test --package <crate-name>` -- typically takes 40 seconds per crate.
 - **WARNING**: Full test suite via `make test` requires building WebAssembly test fixtures and consumes significant memory and disk space. It may fail with "No space left on device" in constrained environments.
 
 ### CLI Usage and Validation
+
 - Test CLI installation: `stellar --version`
 - Basic CLI validation: `stellar --help`
 - Generate test keys: `stellar keys generate <name>`
@@ -39,6 +43,7 @@ Stellar CLI is a Rust-based command-line tool for interacting with the Stellar n
 ## Common Tasks
 
 ### Repository Structure
+
 ```
 /home/runner/work/stellar-cli/stellar-cli/
 ├── cmd/
@@ -55,6 +60,7 @@ Stellar CLI is a Rust-based command-line tool for interacting with the Stellar n
 ```
 
 ### Key Commands Reference
+
 ```bash
 # Development workflow
 cargo build --bin stellar        # Quick build (45s)
@@ -74,6 +80,7 @@ stellar keys address test      # Test key operations
 ```
 
 ### Build Time Expectations
+
 - **NEVER CANCEL** any build or test command before these timeouts:
   - `cargo build --bin stellar`: 2 minutes timeout minimum
   - `make install`: 10 minutes timeout (network issues common)
@@ -82,25 +89,30 @@ stellar keys address test      # Test key operations
   - Core library tests: 5 minutes timeout minimum
 
 ### Known Issues
+
 - **Network timeouts**: `make install` frequently encounters network timeouts with crates.io. This is normal in CI environments.
 - **Memory constraints**: Full workspace build and test may fail with OOM or "No space left on device" errors in constrained environments.
-- **Documentation generation**: `make generate-full-help-doc` may fail due to disk space constraints.
+- **Documentation generation**: `make docs` may fail due to disk space constraints.
 
 ### Working Around Constraints
+
 - Use `cargo build --bin stellar` instead of full workspace build for development
 - Test individual packages with `cargo test --package <name>` instead of full test suite
 - Use `cargo install --force --locked --path ./cmd/stellar-cli` as alternative to `make install`
 
 ## Critical Warnings
+
 - **NEVER CANCEL builds or tests** before the specified timeout periods
 - **Always validate changes** by building and testing the CLI before committing
 - **Network issues are common** - retry `make install` if it fails with timeouts
 - **Use surgical builds** when possible to avoid memory/disk issues
 
 ## CI/CD Integration
+
 The project uses GitHub Actions with workflows in `.github/workflows/`:
+
 - `rust.yml`: Main CI pipeline with formatting, linting, building, and testing
 - `e2e.yml`: End-to-end system tests
 - `binaries.yml`: Multi-platform binary builds
 
-Always run `make fmt` and `make check` locally before pushing to ensure CI passes.
+Always run `make fmt` and `make check` locally before pushing to ensure CI passes.

.github/workflows/binaries.yml

@@ -111,10 +111,15 @@ jobs:
           name: ${{ env.ARTIFACT_NAME }}
       - name: Uncompress Artifact
         run: tar xvf ${{ env.ARTIFACT_NAME }}
+      - shell: powershell
+        run: winget install --id JRSoftware.InnoSetup --scope machine --silent --accept-package-agreements --accept-source-agreements
+      - shell: powershell
+        run: |
+          $innoPath = "C:\Program Files (x86)\Inno Setup 6"
+          echo $innoPath | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append
       - name: Build Installer
         shell: powershell
         run: |
-          $Env:Path += ";C:\Users\$Env:UserName\AppData\Local\Programs\Inno Setup 6"
           $Env:STELLAR_CLI_VERSION = "${{ env.VERSION }}"
           ISCC.exe installer.iss
           mv Output/stellar-installer.exe ${{ env.STELLAR_CLI_INSTALLER }}

.github/workflows/docs.yml

@@ -6,7 +6,8 @@ on:
   pull_request:
 
 concurrency:
-  group: ${{ github.workflow }}-${{ github.ref_protected == 'true' && github.sha || github.ref }}
+  group:
+    ${{ github.workflow }}-${{ github.ref_protected == 'true' && github.sha || github.ref }}
   cancel-in-progress: true
 
 jobs:

.github/workflows/e2e.yml

@@ -39,7 +39,7 @@ jobs:
     if: github.event_name != 'push'
     uses: stellar/system-test/.github/workflows/test.yml@master
     with:
-      js-stellar-sdk-npm-version: v14.0.0-rc.3
+      js-stellar-sdk-npm-version: v14.2.0
       stellar-cli-ref: ${{ github.ref }}
       test-filter: "^TestDappDevelop$/^.*$"
       runner: "ubuntu-latest"

.github/workflows/rust.yml

@@ -31,9 +31,8 @@ jobs:
     if: always()
     needs:
       [
-        fmt,
         cargo-deny,
-        check-generated-full-help-docs,
+        check,
         build-and-test,
         build-and-test-macos,
         build-and-test-windows,
@@ -42,18 +41,9 @@ jobs:
       ]
     runs-on: ubuntu-latest
     steps:
-      - if:
-          contains(needs.*.result, 'failure') || contains(needs.*.result,
-          'cancelled')
+      - if: contains(needs.*.result, 'failure') || contains(needs.*.result, 'cancelled')
         run: exit 1
 
-  fmt:
-    runs-on: ubuntu-latest-8-cores
-    steps:
-      - uses: actions/checkout@v5
-      - run: rustup update
-      - run: cargo fmt --all --check
-
   cargo-deny:
     runs-on: ubuntu-latest
     strategy:
@@ -67,15 +57,15 @@ jobs:
         with:
           command: check ${{ matrix.check }}
 
-  check-generated-full-help-docs:
+  check:
     runs-on: ubuntu-latest-8-cores
     steps:
       - uses: actions/checkout@v5
       - uses: stellar/actions/rust-cache@main
-      - run: rustup update
       - run: sudo apt update && sudo apt install -y libudev-dev libdbus-1-dev
-      - run: make generate-full-help-doc
-      - run: git add -N . && git diff HEAD --exit-code
+      - run: rustup update
+      - run: npm install
+      - run: make check
 
   build-and-test:
     strategy:
@@ -96,9 +86,7 @@ jobs:
           rust-version: ${{ matrix.rust }}
 
   build-and-test-macos:
-    if:
-      github.ref == 'refs/heads/main' || startsWith(github.ref,
-      'refs/heads/release/') || startsWith(github.head_ref, 'release/')
+    if: github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/heads/release/') || startsWith(github.head_ref, 'release/')
     strategy:
       fail-fast: false
       matrix:
@@ -117,9 +105,7 @@ jobs:
           rust-version: ${{ matrix.rust }}
 
   build-and-test-windows:
-    if:
-      github.ref == 'refs/heads/main' || startsWith(github.ref,
-      'refs/heads/release/') || startsWith(github.head_ref, 'release/')
+    if: github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/heads/release/') || startsWith(github.head_ref, 'release/')
     strategy:
       fail-fast: false
       matrix:
@@ -161,23 +147,20 @@ jobs:
           - os: ubuntu-latest-8-cores
             target: x86_64-unknown-linux-gnu
             cargo-hack-feature-options:
-              --feature-powerset --skip emulator-tests --group-features default
-              --ignore-unknown-features
+              --feature-powerset --skip emulator-tests
             additional-deb-packages: libudev-dev libdbus-1-dev
           #        - os: ubuntu-jammy-8-cores-arm64
           #          target: aarch64-unknown-linux-gnu
-          #          cargo-hack-feature-options: --feature-powerset --skip emulator-tests --group-features default --ignore-unknown-features
+          #          cargo-hack-feature-options: --feature-powerset --skip emulator-tests default
           #          additional-deb-packages: libudev-dev libssl-dev libdbus-1-dev
           - os: macos-13
             target: x86_64-apple-darwin
             cargo-hack-feature-options:
-              --feature-powerset --skip emulator-tests --group-features default
-              --ignore-unknown-features
+              --feature-powerset --skip emulator-tests
           - os: macos-latest
             target: aarch64-apple-darwin
             cargo-hack-feature-options:
-              --feature-powerset --skip emulator-tests --group-features default
-              --ignore-unknown-features
+              --feature-powerset --skip emulator-tests
           # Windows builds notes:
           #
           # The different features that need testing are split over unique