additional-libs feature for keyring dependencies (secure store)#1977
Merged
Conversation
- move write_to_secure_store to keyring.rs
elizabethengelman
force-pushed
the
feat/additional-libs-feature
branch
from
d0ce2cd to
f35699a
Compare
In upcoming refactors, secret.rs and locator.rs are going to depend on secure_store directly, instead of keyring.rs so that keyring.rs can be entirely behind a feature flag. Without the changes in this commit there is a cyclical dependency on secret -> secure_store -> secret. Same for locator.
this mod is only included when the feature is enabled
elizabethengelman
force-pushed
the
feat/additional-libs-feature
branch
from
0c3534f to
3e1be6a
Compare
elizabethengelman
force-pushed
the
feat/additional-libs-feature
branch
from
3e1be6a to
ac6013d
Compare
ifropc
reviewed
Apr 4, 2025
elizabethengelman
force-pushed
the
feat/additional-libs-feature
branch
from
e08da9a to
8b9e16d
Compare
elizabethengelman
changed the title
…ng) (#2011) * Add stellar-ledger crate to additional-libs feature, and make optional * Create a GenericLedger for when additional-libs feature is not enabled * Change ledger::ledger fn to ledger::new * Simplify ledger_impl * Move stellar-ledger specific things to ledger_impl * Move ledger feature switching to ledger.rs * Enable additional-libs in emulator workflow
fnando
approved these changes
Apr 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds an
additional-libsfeature so that users can build and use the CLI (without keyring support) without havinglibdbus-1-devinstalled on their systemWhy
Allows for a smaller binary, and less system dependencies.
Known limitations
This PR only handles the keyring dependencies, I'll put the ledger work in a separate PR: #2011
Also, I still need to do a bit more testing of this change on a linux vm.tested on macos and ubuntu