Hack fix to the address resolution in the snapshot create command#2210
Closed
leighmcculloch wants to merge 1 commit into
Closed
Hack fix to the address resolution in the snapshot create command#2210leighmcculloch wants to merge 1 commit into
leighmcculloch wants to merge 1 commit into
Conversation
Member
|
@leighmcculloch do we want to merge this in? Does it need anything else? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Hack fix to the address resolution in the snapshot create command.
Why
To unblock @kalepail affected by #2207.
Known limitations
This change probably doesn't address the full issue with address resolution. I see multiple functions that all seem to have a mistaken assumption that ScAdderss only contains contract addresses, when it can also contain an account address. This PR is just open teporarily to unblock @kalepail and isn't intended for merging. But it may help inform the final fix for the issue too.
Usage
To use this change instead of the release stellar-cli, install from source using the following command: