Skip to content

Remove unreliable print function. #2220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fnando merged 1 commit into from
Sep 24, 2025
Merged

Remove unreliable print function. #2220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cmd/soroban-cli/src/commands/snapshot/create.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,10 +277,10 @@ impl Cmd {
.map_err(Error::ReadOpeningCachedBucket)?;

let message = format!("Searching bucket {i} {bucket}");
print.search(format!("{message}…"));
print.searchln(format!("{message}…"));

if let Ok(metadata) = file.metadata() {
print.clear_line();
print.clear_previous_line();
print.searchln(format!("{message} ({})", ByteSize(metadata.len())));
}

Expand Down
8 changes: 0 additions & 8 deletions cmd/soroban-cli/src/print.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,14 +31,6 @@ impl Print {
}
}

pub fn clear_line(&self) {
if cfg!(windows) {
eprint!("\r");
} else {
eprint!("\r\x1b[2K");
}
}

pub fn clear_previous_line(&self) {
if !self.quiet {
if cfg!(windows) {
Expand Down