Fix panic when global config dir does not exist yet#2497
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Prevents print_deprecation_warning from panicking when the computed global config directory path doesn’t exist yet (e.g., first-run scenarios), improving CLI robustness for read-only commands that still trigger the local-config deprecation warning.
Changes:
- Replace
fs::canonicalize(...).expect(...)with a non-panicking fallback when canonicalization fails. - Add a regression test to ensure
print_deprecation_warningdoesn’t panic when the global config dir is missing.
mootz12
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Do not crash when global dir cannot be expanded.
Why
Having a local config directory and no global directory was failing, even for commands that are read-only.
Known limitations
N/A