Skip to content

Upgrade stellar-rpc-client.#2498

Merged
fnando merged 4 commits intomainfrom
upgrade-deps
Apr 20, 2026
Merged

Upgrade stellar-rpc-client.#2498
fnando merged 4 commits intomainfrom
upgrade-deps

Conversation

@fnando
Copy link
Copy Markdown
Member

@fnando fnando commented Apr 17, 2026

What

Upgrade stellar-rpc-client.

Why

The package includes some vulnerable dependencies upgrades.

Known limitations

N/A

Copilot AI review requested due to automatic review settings April 17, 2026 18:43
@github-project-automation github-project-automation bot moved this to Backlog (Not Ready) in DevX Apr 17, 2026
@fnando fnando requested review from mootz12 and removed request for Copilot April 17, 2026 18:43
@fnando fnando self-assigned this Apr 17, 2026
@fnando fnando moved this from Backlog (Not Ready) to Needs Review in DevX Apr 17, 2026
@fnando fnando enabled auto-merge (squash) April 17, 2026 18:45
Copilot AI review requested due to automatic review settings April 17, 2026 21:17
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Upgrades the workspace’s stellar-rpc-client dependency to 26.0.0-rc.2 to pick up dependency/security fixes, along with small refactors needed to align with updated dependency APIs.

Changes:

  • Bump stellar-rpc-client from 26.0.0-rc.1 to 26.0.0-rc.2 and refresh Cargo.lock.
  • Remove direct jsonrpsee-* deps/usages from soroban-cli and switch relevant types/imports (e.g., serde::Serialize, reqwest::header::HeaderMap).
  • Clean up various formatting / minor refactors (match guards, trailing commas) and update deny.toml advisory ignores.

Reviewed changes

Copilot reviewed 19 out of 20 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
deny.toml Removes no-longer-needed advisory ignore tied to older RPC client deps.
cmd/soroban-cli/src/upgrade_check.rs Minor change to update-check interval construction.
cmd/soroban-cli/src/signer/mod.rs Formatting cleanup (remove trailing comma in format!).
cmd/soroban-cli/src/log/event.rs Refactors diagnostic log event matching using a match guard.
cmd/soroban-cli/src/log/cost.rs Formatting cleanup (remove trailing commas in writeln!).
cmd/soroban-cli/src/config/upgrade_check.rs Switches Serialize import to serde::Serialize (drops jsonrpsee core usage).
cmd/soroban-cli/src/config/network.rs Switches HeaderMap import to reqwest::header::HeaderMap.
cmd/soroban-cli/src/config/data.rs Formatting cleanup (remove trailing comma in write!).
cmd/soroban-cli/src/commands/snapshot/create.rs Refactors match arm using a guard for wasm search behavior.
cmd/soroban-cli/src/commands/doctor.rs Formatting cleanup (remove trailing comma in format!).
cmd/soroban-cli/src/commands/contract/upload.rs Removes jsonrpsee-specific error variant in favor of rpc::Error.
cmd/soroban-cli/src/commands/contract/init.rs Simplifies file_exists and removes unused Metadata import.
cmd/soroban-cli/src/commands/contract/deploy/wasm.rs Removes jsonrpsee-specific error variant in favor of rpc::Error.
cmd/soroban-cli/src/commands/contract/arg_parsing.rs Small refactor using Result::is_ok_and for spec lookup check.
cmd/soroban-cli/Cargo.toml Drops direct jsonrpsee-http-client / jsonrpsee-core dependencies.
cmd/crates/stellar-ledger/src/emulator_test_support/http_transport.rs Adjusts request timeout construction.
cmd/crates/soroban-test/tests/it/build.rs Formatting cleanup (remove trailing comma in format!).
cmd/crates/soroban-spec-typescript/src/lib.rs Refactors constructor detection logic using a match guard.
Cargo.toml Bumps workspace stellar-rpc-client version and removes jsonrpsee deps from workspace deps.
Cargo.lock Lockfile refresh reflecting upgraded RPC client and transitive dependency changes.

Comment thread cmd/soroban-cli/src/log/event.rs Outdated
@fnando fnando merged commit f507395 into main Apr 20, 2026
213 checks passed
@fnando fnando deleted the upgrade-deps branch April 20, 2026 18:46
@github-project-automation github-project-automation bot moved this from Needs Review to Done in DevX Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants