Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Upgrades the workspace’s stellar-rpc-client dependency to 26.0.0-rc.2 to pick up dependency/security fixes, along with small refactors needed to align with updated dependency APIs.
Changes:
- Bump
stellar-rpc-clientfrom26.0.0-rc.1to26.0.0-rc.2and refreshCargo.lock. - Remove direct
jsonrpsee-*deps/usages fromsoroban-cliand switch relevant types/imports (e.g.,serde::Serialize,reqwest::header::HeaderMap). - Clean up various formatting / minor refactors (match guards, trailing commas) and update
deny.tomladvisory ignores.
Reviewed changes
Copilot reviewed 19 out of 20 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
deny.toml |
Removes no-longer-needed advisory ignore tied to older RPC client deps. |
cmd/soroban-cli/src/upgrade_check.rs |
Minor change to update-check interval construction. |
cmd/soroban-cli/src/signer/mod.rs |
Formatting cleanup (remove trailing comma in format!). |
cmd/soroban-cli/src/log/event.rs |
Refactors diagnostic log event matching using a match guard. |
cmd/soroban-cli/src/log/cost.rs |
Formatting cleanup (remove trailing commas in writeln!). |
cmd/soroban-cli/src/config/upgrade_check.rs |
Switches Serialize import to serde::Serialize (drops jsonrpsee core usage). |
cmd/soroban-cli/src/config/network.rs |
Switches HeaderMap import to reqwest::header::HeaderMap. |
cmd/soroban-cli/src/config/data.rs |
Formatting cleanup (remove trailing comma in write!). |
cmd/soroban-cli/src/commands/snapshot/create.rs |
Refactors match arm using a guard for wasm search behavior. |
cmd/soroban-cli/src/commands/doctor.rs |
Formatting cleanup (remove trailing comma in format!). |
cmd/soroban-cli/src/commands/contract/upload.rs |
Removes jsonrpsee-specific error variant in favor of rpc::Error. |
cmd/soroban-cli/src/commands/contract/init.rs |
Simplifies file_exists and removes unused Metadata import. |
cmd/soroban-cli/src/commands/contract/deploy/wasm.rs |
Removes jsonrpsee-specific error variant in favor of rpc::Error. |
cmd/soroban-cli/src/commands/contract/arg_parsing.rs |
Small refactor using Result::is_ok_and for spec lookup check. |
cmd/soroban-cli/Cargo.toml |
Drops direct jsonrpsee-http-client / jsonrpsee-core dependencies. |
cmd/crates/stellar-ledger/src/emulator_test_support/http_transport.rs |
Adjusts request timeout construction. |
cmd/crates/soroban-test/tests/it/build.rs |
Formatting cleanup (remove trailing comma in format!). |
cmd/crates/soroban-spec-typescript/src/lib.rs |
Refactors constructor detection logic using a match guard. |
Cargo.toml |
Bumps workspace stellar-rpc-client version and removes jsonrpsee deps from workspace deps. |
Cargo.lock |
Lockfile refresh reflecting upgraded RPC client and transitive dependency changes. |
mootz12
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Upgrade stellar-rpc-client.
Why
The package includes some vulnerable dependencies upgrades.
Known limitations
N/A