Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR completes the v26 removal of reading deprecated local config directories (e.g. .stellar), while still detecting their presence and warning users to migrate—addressing the --config-dir ancestor-search secret disclosure described in issue #2493.
Changes:
- Make local-config discovery use the real process cwd (so
--config-dirno longer seeds ancestor search). - Stop reading/listing identities and contract aliases from local config, but emit deprecation/migration warnings when local config is detected.
- Update soroban-test integration helpers/tests to write/read identities from the global config directory layout.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| cmd/soroban-cli/src/config/locator.rs | Avoids --config-dir ancestor-walk for local discovery; skips local reads/lists while warning; adds regression tests. |
| cmd/crates/soroban-test/tests/it/util.rs | Updates test helper to write identities directly into the global config dir structure. |
| cmd/crates/soroban-test/tests/it/config.rs | Adjusts integration tests to use sandbox.config_dir() paths and global-layout expectations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Stop reading from local config directory. We're still checking for .stellar directories and warning about the required migration.
Why
To complete the removal from v26. Close #2493
Known limitations
N/A