Shell-escape build command args in --print-commands-only output.#2502
Open
Shell-escape build command args in --print-commands-only output.#2502
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a command-injection risk in stellar contract build --print-commands-only by ensuring the printed Cargo invocation is shell-safe when it contains user-controlled paths (e.g., --manifest-path).
Changes:
- Refactors command string building into a
serialize_command()helper. - Shell-escapes all serialized command arguments (not just environment variable values) before printing.
- Adds a unit test to validate escaping behavior for metacharacter-containing args.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Shell-escape build command args in --print-commands-only output.
Why
Close #2490
Known limitations
N/A