Honor --docker-host flag for TCP/HTTP Docker connections.#2503
Open
Honor --docker-host flag for TCP/HTTP Docker connections.#2503
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes stellar container Docker connection behavior so an explicit --docker-host value is honored for TCP/HTTP connections instead of being overridden by environment defaults, addressing the precedence bypass described in issue #2496.
Changes:
- Use Bollard’s
Docker::connect_with_http(&h, ...)fortcp://andhttp://hosts so the resolved CLI host is used. - Preserve existing behavior for unix socket / named pipe connections while aligning TCP/HTTP with the same precedence rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Honor --docker-host flag for TCP/HTTP Docker connections.
Why
Close #2496
Known limitations
N/A