Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #2492 by ensuring Secure Store (keyring) entries are actually updated when a key is overwritten, preventing the CLI from continuing to reference stale key material after a successful-looking overwrite.
Changes:
- Thread an
overwrite: boolflag throughsecure_store::save_secretintoStellarEntry::write. - Change keyring write behavior to error on existing entries unless overwrite is explicitly allowed, and to always persist the new seed phrase when overwriting.
- Add unit tests covering overwrite and non-overwrite behavior for keyring writes.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| cmd/soroban-cli/src/signer/secure_store.rs | Adds overwrite parameter and forwards it to keyring entry writes. |
| cmd/soroban-cli/src/signer/keyring.rs | Implements overwrite-aware keyring writes and adds tests for the new semantics. |
| cmd/soroban-cli/src/commands/keys/generate.rs | Passes CLI --overwrite through to Secure Store save path. |
| cmd/soroban-cli/src/commands/keys/add.rs | Passes CLI --overwrite through to Secure Store save path. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Prevent stale keyring entry when overwriting a key
Why
Close #2492
Known limitations
N/A