Skip to content

chore: startup quickstart before ledger tests#2575

Merged
fnando merged 3 commits intomainfrom
fix-emulator-test
May 8, 2026
Merged

chore: startup quickstart before ledger tests#2575
fnando merged 3 commits intomainfrom
fix-emulator-test

Conversation

@mootz12
Copy link
Copy Markdown
Contributor

@mootz12 mootz12 commented May 8, 2026

What

Run quickstart before emulator tests in CI

Why

New emulator tests submit transactions

Known limitations

Quickstart can be slow to start in CI. Two alternatives:

  1. Once tx sign supports auth entries, use that directly instead of submitting transactions
  2. Run emulator tests in rpc-test job

@mootz12 mootz12 requested review from Copilot and fnando May 8, 2026 20:37
@github-project-automation github-project-automation Bot moved this to Backlog (Not Ready) in DevX May 8, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Ledger Emulator Tests GitHub Actions workflow to start Stellar Quickstart before running emulator-related tests, ensuring a local RPC/network is available for tests that now submit transactions.

Changes:

  • Add a stellar/quickstart startup step to the ledger-emulator CI workflow prior to running tests.

Comment thread .github/workflows/ledger-emulator.yml
@fnando fnando enabled auto-merge (squash) May 8, 2026 22:59
@fnando fnando merged commit 62d214a into main May 8, 2026
211 checks passed
@fnando fnando deleted the fix-emulator-test branch May 8, 2026 23:03
@github-project-automation github-project-automation Bot moved this from Backlog (Not Ready) to Done in DevX May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants