AP: Copy over commits from ap-v3 branch (#969)

* [ANCHOR-417] Remove /fee callbacks

* [ANCHOR-443] Remove transaction_erropr event type

* [ANCHOR-442] Unify platform txn schemas

* Regenerate

* Remove dead link

Author: philipliu

openapi/anchor-platform/bundled-callbacks.yaml

@@ -15,8 +15,6 @@ servers:
 tags:
   - name: Unique Address
     description: (optional) Provide a unique `stellar_address:memo` pair that will be used to correlate a Stellar payment 1-to-1 with a Platform resource such as a [SEP-31](https://stellar.org/protocol/sep-31) transaction.
-  - name: Fees
-    description: Requests containing data that can be used to calculate transaction fees.
   - name: Rates
     description: Requests containing data that can be used to provide exchange rates between on & off-chain assets.
   - name: Customers
@@ -85,104 +83,6 @@ paths:
             application/json:
               schema:
                 $ref: '#/components/schemas/Error'
-  /fee:
-    get:
-      description: |
-        The Platform will make this request to the anchor every time a transaction is initiated by a client application
-        without a `quote_id`.
-
-        The Anchor must ensure that the sending and receiving customers specified in the request meet the KYC requirements
-        necessary to partake in the transaction described in the request.
-
-        The anchor must return the fee it will charge for the transaction.
-
-        In the future, this endpoint may be used to provide estimated fees to client applications prior to initiating transactions.
-        When this change is made, the request schema will be adapted to support the use case.
-      tags:
-        - Fees
-      x-seps:
-        - SEP-31
-      summary: Retrieve Fees
-      operationId: getFee
-      parameters:
-        - in: query
-          name: send_asset
-          description: |
-            The asset the client application will send to the anchor in exchange for `receive_asset` in
-            [Asset Identification Format](https://github.com/stellar/stellar-protocol/blob/master/ecosystem/sep-0038.md#asset-identification-format).
-          schema:
-            type: string
-          required: true
-        - in: query
-          name: receive_asset
-          description: |
-            The asset the that the anchor will send in exchange for `send_asset` in
-            [Asset Identification Format](https://github.com/stellar/stellar-protocol/blob/master/ecosystem/sep-0038.md#asset-identification-format).
-          schema:
-            type: string
-          required: true
-        - in: query
-          name: send_amount
-          description: |
-            The amount of `send_asset` the client application will send in exchange for `receive_asset`. One of `send_amount`
-            or `receive_amount` will always be included in the request. If the client application specified a `quote_id` in
-            its transaction creation request, both amounts specified in the referenced quote will be passed.
-          schema:
-            type: string
-        - in: query
-          name: receive_amount
-          description: |
-            The amount of `receive_asset` the anchor will send in exchange for `send_asset`. One of `send_amount` or
-            `receive_amount` will always be included in the request. If the client application specified a `quote_id` in its
-            transaction creation request, both amounts specified in the referenced quote will be passed.
-          schema:
-            type: string
-        - in: query
-          name: client_id
-          description: |
-            An identifier for the client application making the request. This ID can be used to offer different fees to different clients.
-            A client ID it the Stellar account of a sending anchor: In SEP-31, the `client_id` should match the account of a known SEP-31 sending anchor match the one used to authenticate via SEP-10.
-          schema:
-            type: string
-          required: true
-        - in: query
-          name: sender_id
-          description: |
-            The SEP-12 customer ID of the sending user.
-          schema:
-            type: string
-          required: true
-        - in: query
-          name: receiver_id
-          description: |
-            The SEP-12 customer ID of the receiving user.
-          schema:
-            type: string
-          required: true
-      responses:
-        '200':
-          description: Success.
-          content:
-            application/json:
-              schema:
-                $ref: '#/components/schemas/FeeResponse'
-        '422':
-          description: |
-            Unprocessable Entity. This status should be returned when the anchor understood the request but cannot
-            return a success response. An example for when this response code would be appropriate is if the sender
-            and/or receiver is not permitted to initiate a transaction with the specified amounts. In these cases,
-            the Platform will respond to the client application's request with a `400 Bad Request` and include the
-            error message provided by the anchor in the response body.
-          content:
-            application/json:
-              schema:
-                $ref: '#/components/schemas/Error'
-        '500':
-          description: Error. The Platform will respond to the client application with the same response code and body.
-          content:
-            application/json:
-              schema:
-                $ref: '#/components/schemas/Error'
   /rate:
     get:
       description: |
@@ -542,21 +442,6 @@ components:
           type: string
       required:
         - error
-    Amount:
-      type: object
-      required:
-        - amount
-        - asset
-      properties:
-        amount:
-          type: string
-        asset:
-          type: string
-    FeeResponse:
-      type: object
-      properties:
-        fee:
-          $ref: '#/components/schemas/Amount'
     RateFeeDetailResponse:
       type: object
       properties:
@@ -956,6 +841,16 @@ components:
         - no_market
         - too_small
         - too_large
+    Amount:
+      type: object
+      required:
+        - amount
+        - asset
+      properties:
+        amount:
+          type: string
+        asset:
+          type: string
     FeeDescription:
       type: object
       required:
@@ -1073,6 +968,26 @@ components:
       description: The memo type of the transaction in the Stellar network. Should be present if memo is not null.
       enum:
         - text id hash
+    StellarId:
+      type: object
+      description: |
+        StellarId's are objects that identify end-users and SEP-31 Sending Anchors, but not SEP-31 Receiving Anchors.
+
+        For a SEP-12 customer, the `id` field should be sufficient to fully identify the customer in the business' Backend.
+
+        For a SEP-31 Sending Anchor, the `account` and `memo` fields should be used.
+
+        For a SEP-6 or SEP-24 Anchor, the `account` and `memo` fields should be used.
+      properties:
+        id:
+          type: string
+          description: The `id` of the customer registered through SEP-12.
+        account:
+          type: string
+          description: Either the Stellar account or Muxed account address of the on-chain entity.
+        memo:
+          type: string
+          description: The memo value identifying a customer with a shared account, where the shared account is `account`.
     TransactionSEP24:
       type: object
       required:
@@ -1097,6 +1012,9 @@ components:
             - withdrawal
         status:
           $ref: '#/components/schemas/StatusSEP24'
+        type:
+          type: string
+          description: This field is always empty for SEP-24 transactions.
         amount_expected:
           $ref: '#/components/schemas/Amount'
         amount_in:
@@ -1119,6 +1037,9 @@ components:
         transfer_received_at:
           type: string
           format: date-time
+        user_action_required_by:
+          type: string
+          format: date-time
         message:
           type: string
         refunds:
@@ -1138,14 +1059,25 @@ components:
         memo_type:
           $ref: '#/components/schemas/MemoType'
         refund_memo:
-          description: if provided, this memo should be used for refund transactions
+          description: If provided, this memo should be used for refund transactions.
           type: string
         refund_memo_type:
           $ref: '#/components/schemas/MemoType'
         client_domain:
           type: string
         client_name:
           type: string
+        customers:
+          type: object
+          description: |
+            The user that initiated the transaction is both the sender and receiver.
+          properties:
+            sender:
+              $ref: '#/components/schemas/StellarId'
+            receiver:
+              $ref: '#/components/schemas/StellarId'
+        creator:
+          $ref: '#/components/schemas/StellarId'
     StatusSEP31:
       type: string
       description: Possible status value for SEP-31 transactions
@@ -1161,26 +1093,6 @@ components:
         - pending_receiver
         - pending_transaction_info_update
         - pending_customer_info_update
-    StellarId:
-      type: object
-      description: |
-        StellarId's are objects that identify end-users and SEP-31 Sending Anchors, but not SEP-31 Receiving Anchors.
-
-        For a SEP-12 customer, the `id` field should be sufficient to fully identify the customer in the business' Backend.
-
-        For a SEP-31 Sending Anchor, the `account` and `memo` fields should be used.
-
-        For a SEP-6 Anchor, the `account` and `memo` fields should be used.
-      properties:
-        id:
-          type: string
-          description: The `id` of the customer registered through SEP-12.
-        account:
-          type: string
-          description: Either the Stellar account or Muxed account address of the on-chain entity.
-        memo:
-          type: string
-          description: The memo value identifying a customer with a shared account, where the shared account is `account`.
     TransactionSEP31:
       type: object
       required:
@@ -1202,6 +1114,9 @@ components:
             - receive
         status:
           $ref: '#/components/schemas/StatusSEP31'
+        type:
+          type: string
+          description: This field is always empty for SEP-31 transactions.
         amount_expected:
           $ref: '#/components/schemas/Amount'
         amount_in:
@@ -1224,6 +1139,9 @@ components:
         transfer_received_at:
           type: string
           format: date-time
+        user_action_required_by:
+          type: string
+          format: date-time
         message:
           type: string
         refunds:
@@ -1232,8 +1150,21 @@ components:
           type: array
           items:
             $ref: '#/components/schemas/StellarTransaction'
+        source_account:
+          type: string
+        destination_account:
+          type: string
         external_transaction_id:
           type: string
+        memo:
+          type: string
+        memo_type:
+          $ref: '#/components/schemas/MemoType'
+        refund_memo:
+          description: if provided, this memo should be used for refund transactions.
+          type: string
+        refund_memo_type:
+          $ref: '#/components/schemas/MemoType'
         client_domain:
           type: string
         client_name:
@@ -1292,14 +1223,12 @@ components:
           enum:
             - transaction_created
             - transaction_status_changed
-            - transaction_error
             - quote_created
             - customer_updated
           description: |
             The transaction event type. Can be one of the following:
             - `transaction_created` - a transaction was created through the SEP endpoints. The payload is in the `transaction` field.
             - `transaction_status_changed` - the status of a transaction has changed. The payload is in the `transaction` field.
-            - `transaction_error` - error processing the transaction. The payload is in the `transaction` field.
             - `quote_created` - a quote was created via the SEP38 API. The payload is in the `quote` field.
         timestamp:
           type: string