Use Google Drive embed screen in existing meeting files#2362
Open
JFWooten4 wants to merge 9 commits intostellar:mainfrom
Open
Use Google Drive embed screen in existing meeting files#2362JFWooten4 wants to merge 9 commits intostellar:mainfrom
JFWooten4 wants to merge 9 commits intostellar:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In similar spirit to #2361, this updates the meeting pages that use a Google Drive video. Right now, the default embed script copied over has a few problems.
First, it takes two clicks to start videos after the page loads. It's a little annoying, especially on mobile. Basically, you have to press around a bunch and then you can accidentally pause it. Plus, it's more convoluted to get into fullscreen quickly.
This fixes that and applies the core rounding existence in the YouTube script. I think it's a very reasonable edge (based on the already merged embed script) that keeps the site looking clean around the videos. I'd be remiss not to mention that we are still missing public access to
2024/07/25. But not a big deal in simplifying the import.Also, the existing imports have inconsistent view sizes. Some meetings are square, some are 16 by 9, some use
width="500", others are much larger. This PR standardizes all that. There is only one source video that's actually square because of the recording setup. All the others need to conform to a horizontal display anyway.1Footnotes
And that edge case displays just fine under the standardized method here. ↩