Use custom audio embed screen in existing meeting files#2363
Open
JFWooten4 wants to merge 11 commits intostellar:mainfrom
Open
Use custom audio embed screen in existing meeting files#2363JFWooten4 wants to merge 11 commits intostellar:mainfrom
JFWooten4 wants to merge 11 commits intostellar:mainfrom
Conversation
Contributor
|
@JFWooten4 Can we adjust so this isn't touching the Spanish pages? |
Contributor
Author
|
Sure all done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a similar spirit to #2361 and #2362, this new script drastically simplifies the page imports for old audio archives. Thankfully, we've migrated to YouTube for new content, which has the added benefit of automatic, free transcription. But these old ones still carry significant protocol developments, captions or no.
I was quite uninspired by the original default audio element. It works fine even with the messy imports, but I decided to throw in a little style with my rendition. It colors and rounds the element in accordance with the style unification principles apparent in the brand kit.
I only used
maxWidthso that we can set a reasonable size while maintaining mobile compatibility. If we try setting height too, it can render strangely on small devices.