Skip to content

CONS-341: Fix/drop type hint from wp callback #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dpanta94 merged 3 commits into from
May 21, 2026
+6 −1
Merged

CONS-341: Fix/drop type hint from wp callback #164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6c32a9e
fix: dropped typehint from wp attached callback
dpanta94 May 21, 2026
bb97218
chore: added changelog
dpanta94 May 21, 2026
ba34628
chore: spelling issues
dpanta94 May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions changelog/fix-drop-type-hint-from-wp-callback.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
significance: patch
type: fix
entry: Type-hint in WP Core's callback was too strict and could cause fatal.
timestamp: 2026-05-21T15:02:34.497Z
3 changes: 2 additions & 1 deletion src/Harbor/Admin/Feature_Manager_Page.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,12 +128,13 @@ public function maybe_register_page(): void {
* the React bundle is loaded only on this specific admin page.
*
* @since 1.0.0
* @since TBD Dropped string type-hint for $hook_suffix.
*
* @param string $hook_suffix Current admin page hook suffix.
*
* @return void
*/
public function maybe_enqueue_assets( string $hook_suffix ): void {
public function maybe_enqueue_assets( $hook_suffix ): void {
if ( $hook_suffix !== $this->page_hook ) {
return;
}
Expand Down
Loading