chore: remove all deprecated things (#6669)

* chore: remove all deprecated things

* chore: update tests

Author: johnjenkins

packages/cli/src/_test_/merge-flags.spec.ts

@@ -262,17 +262,6 @@ describe('mergeFlags', () => {
     });
   });
 
-  describe('e2eTests (--e2e)', () => {
-    it('sets e2eTests from --e2e flag', () => {
-      const config: Config = {};
-      const flags = createFlags({ e2e: true });
-
-      const result = mergeFlags(config, flags);
-
-      expect(result.e2eTests).toBe(true);
-    });
-  });
-
   describe('maxConcurrentWorkers (--maxWorkers)', () => {
     it('sets maxConcurrentWorkers from --maxWorkers flag', () => {
       const config: Config = {};

packages/cli/src/_test_/parse-flags.spec.ts

@@ -6,7 +6,6 @@ import {
   BOOLEAN_CLI_FLAGS,
   BOOLEAN_STRING_CLI_FLAGS,
   BooleanStringCLIFlag,
-  ConfigFlags,
   NUMBER_CLI_FLAGS,
   STRING_ARRAY_CLI_FLAGS,
   STRING_CLI_FLAGS,
@@ -298,43 +297,6 @@ describe('parseFlags', () => {
         expect(flags.knownArgs).toEqual(['--config', '/my-config.js']);
       });
     });
-
-    describe('Jest aliases', () => {
-      it.each([
-        ['w', 'maxWorkers', '4'],
-        ['t', 'testNamePattern', 'testname'],
-      ])('should support the string Jest alias %p for %p', (alias, fullArgument, value) => {
-        const flags = parseFlags([`-${alias}`, value]);
-        expect(flags.knownArgs).toEqual([`--${fullArgument}`, value]);
-        expect(flags.unknownArgs).toHaveLength(0);
-      });
-
-      it.each([
-        ['w', 'maxWorkers', '4'],
-        ['t', 'testNamePattern', 'testname'],
-      ])(
-        'should support the string Jest alias %p for %p in an AliasEqualsArg',
-        (alias, fullArgument, value) => {
-          const flags = parseFlags([`-${alias}=${value}`]);
-          expect(flags.knownArgs).toEqual([`--${fullArgument}`, value]);
-          expect(flags.unknownArgs).toHaveLength(0);
-        },
-      );
-
-      it.each<[string, keyof ConfigFlags]>([
-        ['b', 'bail'],
-        ['e', 'expand'],
-        ['o', 'onlyChanged'],
-        ['f', 'onlyFailures'],
-        ['i', 'runInBand'],
-        ['u', 'updateSnapshot'],
-      ])('should support the boolean Jest alias %p for %p', (alias, fullArgument) => {
-        const flags = parseFlags([`-${alias}`]);
-        expect(flags.knownArgs).toEqual([`--${fullArgument}`]);
-        expect(flags[fullArgument]).toBe(true);
-        expect(flags.unknownArgs).toHaveLength(0);
-      });
-    });
   });
 
   it('should parse many', () => {
@@ -361,7 +323,7 @@ describe('parseFlags', () => {
   });
 
   describe.each(STRING_ARRAY_CLI_FLAGS)(
-    'should parse string flag %s',
+    'should parse string array flag %s',
     (cliArg: StringArrayCLIFlag) => {
       it(`should parse single value: "--${cliArg} test-value"`, () => {
         const flags = parseFlags([`--${cliArg}`, 'test-value']);
@@ -452,17 +414,9 @@ describe('parseFlags', () => {
   describe('error reporting', () => {
     it('should throw if you pass no argument to a string flag', () => {
       expect(() => {
-        parseFlags(['--cacheDirectory', '--someOtherFlag']);
-      }).toThrow(
-        'when parsing CLI flag "--cacheDirectory": expected a string argument but received nothing',
-      );
-    });
-
-    it('should throw if you pass no argument to a string array flag', () => {
-      expect(() => {
-        parseFlags(['--reporters', '--someOtherFlag']);
+        parseFlags(['--config', '--someOtherFlag']);
       }).toThrow(
-        'when parsing CLI flag "--reporters": expected a string argument but received nothing',
+        'when parsing CLI flag "--config": expected a string argument but received nothing',
       );
     });
 

packages/cli/src/config-flags.ts

@@ -15,8 +15,6 @@ export const BOOLEAN_CLI_FLAGS = [
   'dev',
   'devtools',
   'docs',
-  // @deprecated - integrated testing will be removed in Stencil v5. See https://github.com/stenciljs/core/issues/6584.
-  'e2e',
   'esm',
   'help',
   'log',
@@ -26,81 +24,18 @@ export const BOOLEAN_CLI_FLAGS = [
   'prod',
   'profile',
   'serviceWorker',
-  // @deprecated - screenshot testing will be removed in Stencil v5. See https://github.com/stenciljs/core/issues/6584.
-  'screenshot',
   'serve',
   'skipNodeCheck',
-  // @deprecated - integrated testing will be removed in Stencil v5. See https://github.com/stenciljs/core/issues/6584.
-  'spec',
   'ssr',
-  // @deprecated - screenshot testing will be removed in Stencil v5. See https://github.com/stenciljs/core/issues/6584.
-  'updateScreenshot',
   'verbose',
   'version',
   'watch',
-
-  // @deprecated - all JEST CLI options below are only used by integrated testing, which will be removed in Stencil v5.
-  // See https://github.com/stenciljs/core/issues/6584.
-  // JEST CLI OPTIONS
-  'all',
-  'automock',
-  'bail',
-  // 'cache', Stencil already supports this argument
-  'changedFilesWithAncestor',
-  // 'ci', Stencil already supports this argument
-  'clearCache',
-  'clearMocks',
-  'collectCoverage',
-  'color',
-  'colors',
-  'coverage',
-  // 'debug', Stencil already supports this argument
-  'detectLeaks',
-  'detectOpenHandles',
-  'errorOnDeprecated',
-  'expand',
-  'findRelatedTests',
-  'forceExit',
-  'init',
-  'injectGlobals',
-  'json',
-  'lastCommit',
-  'listTests',
-  'logHeapUsage',
-  'noStackTrace',
-  'notify',
-  'onlyChanged',
-  'onlyFailures',
-  'passWithNoTests',
-  'resetMocks',
-  'resetModules',
-  'restoreMocks',
-  'runInBand',
-  'runTestsByPath',
-  'showConfig',
-  'silent',
-  'skipFilter',
-  'testLocationInResults',
-  'updateSnapshot',
-  'useStderr',
-  // 'verbose', Stencil already supports this argument
-  // 'version', Stencil already supports this argument
-  // 'watch', Stencil already supports this argument
-  'watchAll',
-  'watchman',
 ] as const;
 
 /**
  * All the Number options supported by the Stencil CLI
  */
-export const NUMBER_CLI_FLAGS = [
-  'port',
-  // @deprecated - all JEST CLI args below are only used by integrated testing, which will be removed in Stencil v5.
-  // See https://github.com/stenciljs/core/issues/6584.
-  // JEST CLI ARGS
-  'maxConcurrency',
-  'testTimeout',
-] as const;
+export const NUMBER_CLI_FLAGS = ['port'] as const;
 
 /**
  * All the String options supported by the Stencil CLI
@@ -112,88 +47,22 @@ export const STRING_CLI_FLAGS = [
   'docsJson',
   'emulate',
   'root',
-  // @deprecated - screenshot testing will be removed in Stencil v5. See https://github.com/stenciljs/core/issues/6584.
-  'screenshotConnector',
-
-  // @deprecated - all JEST CLI args below are only used by integrated testing, which will be removed in Stencil v5.
-  // See https://github.com/stenciljs/core/issues/6584.
-  // JEST CLI ARGS
-  'cacheDirectory',
-  'changedSince',
-  'collectCoverageFrom',
-  // 'config', Stencil already supports this argument
-  'coverageDirectory',
-  'coverageThreshold',
-  'env',
-  'filter',
-  'globalSetup',
-  'globalTeardown',
-  'globals',
-  'haste',
-  'moduleNameMapper',
-  'notifyMode',
-  'outputFile',
-  'preset',
-  'prettierPath',
-  'resolver',
-  'rootDir',
-  'runner',
-  'testEnvironment',
-  'testEnvironmentOptions',
-  'testFailureExitCode',
-  'testNamePattern',
-  'testResultsProcessor',
-  'testRunner',
-  'testSequencer',
-  'testURL',
-  'timers',
-  'transform',
 ] as const;
 
-// @deprecated - all entries below are JEST CLI args only used by integrated testing, which will be removed in Stencil v5.
-// See https://github.com/stenciljs/core/issues/6584.
-export const STRING_ARRAY_CLI_FLAGS = [
-  'collectCoverageOnlyFrom',
-  'coveragePathIgnorePatterns',
-  'coverageReporters',
-  'moduleDirectories',
-  'moduleFileExtensions',
-  'modulePathIgnorePatterns',
-  'modulePaths',
-  'projects',
-  'reporters',
-  'roots',
-  'selectProjects',
-  'setupFiles',
-  'setupFilesAfterEnv',
-  'snapshotSerializers',
-  'testMatch',
-  'testPathIgnorePatterns',
-  'testPathPattern',
-  'testRegex',
-  'transformIgnorePatterns',
-  'unmockedModulePathPatterns',
-  'watchPathIgnorePatterns',
-] as const;
+export const STRING_ARRAY_CLI_FLAGS = [] as const;
 
 /**
  * All the CLI arguments which may have string or number values
  *
- * `maxWorkers` is an argument which is used both by Stencil _and_ by Jest,
- * which means that we need to support parsing both string and number values.
+ * `maxWorkers` controls the number of concurrent workers for Stencil builds.
+ * Supports both string (e.g., "50%") and number values.
  */
 export const STRING_NUMBER_CLI_FLAGS = ['maxWorkers'] as const;
 
 /**
  * All the CLI arguments which may have boolean or string values.
  */
 export const BOOLEAN_STRING_CLI_FLAGS = [
-  /**
-   * `headless` is an argument passed through to Puppeteer (which is passed to Chrome) for end-to-end testing.
-   *
-   * {@see https://developer.chrome.com/blog/chrome-headless-shell/}
-   */
-  'headless',
   /**
    * `stats` is an argument that can optionally accept a file path where stats should be written.
    * When used as a boolean (--stats), it defaults to 'stencil-stats.json'.
@@ -245,25 +114,13 @@ export const CLI_FLAG_ALIASES: AliasMap = {
   h: 'help',
   p: 'port',
   v: 'version',
-
-  // JEST SPECIFIC CLI FLAGS
-  // these are defined in
-  // https://github.com/facebook/jest/blob/4156f86/packages/jest-cli/src/args.ts
-  b: 'bail',
-  e: 'expand',
-  f: 'onlyFailures',
-  i: 'runInBand',
-  o: 'onlyChanged',
-  t: 'testNamePattern',
-  u: 'updateSnapshot',
-  w: 'maxWorkers',
 };
 
 /**
  * A regular expression which can be used to match a CLI flag for one of our
  * short aliases.
  */
-export const CLI_FLAG_REGEX = new RegExp(`^-[chpvbewofitu]{1}$`);
+export const CLI_FLAG_REGEX = new RegExp(`^-[chpv]{1}$`);
 
 /**
  * Given two types `K` and `T` where `K` extends `ReadonlyArray<string>`,

packages/cli/src/merge-flags.ts

@@ -90,11 +90,6 @@ export const mergeFlags = (config: Config, flags: ConfigFlags): Config => {
     merged.generateServiceWorker = flags.serviceWorker;
   }
 
-  // --e2e → e2eTests
-  if (typeof flags.e2e === 'boolean') {
-    merged.e2eTests = flags.e2e;
-  }
-
   // --maxWorkers → maxConcurrentWorkers
   if (typeof flags.maxWorkers === 'number') {
     merged.maxConcurrentWorkers = flags.maxWorkers;

packages/cli/src/parse-flags.ts

@@ -255,13 +255,19 @@ const setCLIArg = (
 
   // We're setting a string, but it's one where the user can pass multiple values,
   // like `--reporters="default" --reporters="jest-junit"`
-  else if (readOnlyArrayHasStringMember(STRING_ARRAY_CLI_FLAGS, normalizedArg)) {
+  // Note: STRING_ARRAY_CLI_FLAGS is currently empty, but we keep the infrastructure
+  // for future CLI flags that accept multiple string values.
+  else if (
+    STRING_ARRAY_CLI_FLAGS.length > 0 &&
+    readOnlyArrayHasStringMember(STRING_ARRAY_CLI_FLAGS, normalizedArg)
+  ) {
     if (typeof value === 'string') {
-      if (!Array.isArray(flags[normalizedArg])) {
-        flags[normalizedArg] = [];
+      const flagsRecord = flags as unknown as Record<string, unknown>;
+      if (!Array.isArray(flagsRecord[normalizedArg])) {
+        flagsRecord[normalizedArg] = [];
       }
 
-      const targetArray = flags[normalizedArg];
+      const targetArray = flagsRecord[normalizedArg];
       // this is irritating, but TS doesn't know that the `!Array.isArray`
       // check above guarantees we have an array to work with here, and it
       // doesn't want to narrow the type of `flags[normalizedArg]`, so we need

packages/cli/src/telemetry/_test_/telemetry.spec.ts

@@ -259,13 +259,11 @@ describe('anonymizeConfigForTelemetry', () => {
   });
 
   it.each<keyof d.ValidatedConfig>([
-    'commonjs',
     'devServer',
     'env',
     'logger',
     'rolldownConfig',
     'sys',
-    'testing',
     'tsCompilerOptions',
   ])("should remove objects under prop '%s'", (prop: keyof d.ValidatedConfig) => {
     const anonymizedConfig = anonymizeConfigForTelemetry({

packages/cli/src/telemetry/telemetry.ts

@@ -260,13 +260,11 @@ const CONFIG_PROPS_TO_ANONYMIZE: ReadonlyArray<ConfigStringKeys> = [
 //
 // TODO(STENCIL-469): Investigate improving anonymization for tsCompilerOptions and devServer
 const CONFIG_PROPS_TO_DELETE: ReadonlyArray<keyof d.Config> = [
-  'commonjs',
   'devServer',
   'env',
   'logger',
   'rolldownConfig',
   'sys',
-  'testing',
   'tsCompilerOptions',
 ];
 

packages/core/src/app-data/index.ts

@@ -31,7 +31,6 @@ export const BUILD: BuildConditionals = {
   hostListenerTargetWindow: true,
   hostListenerTargetDocument: true,
   hostListenerTargetBody: true,
-  hostListenerTargetParent: false,
   hostListenerTarget: true,
   member: true,
   method: true,
@@ -95,8 +94,6 @@ export const BUILD: BuildConditionals = {
   initializeNextTick: false,
   asyncLoading: true,
   asyncQueue: false,
-  // TODO: deprecated in favour of `setTagTransformer` and `transformTag`. Remove in 5.0
-  transformTagName: false,
   attachStyles: true,
   // TODO(STENCIL-914): remove this option when `experimentalSlotFixes` is the default behavior
   experimentalSlotFixes: false,

packages/core/src/compiler/app-core/app-data.ts

@@ -38,7 +38,6 @@ export const getBuildFeatures = (cmps: ComponentCompilerMeta[]): BuildFeatures =
     hostListenerTargetWindow: cmps.some((c) => c.hasListenerTargetWindow),
     hostListenerTargetDocument: cmps.some((c) => c.hasListenerTargetDocument),
     hostListenerTargetBody: cmps.some((c) => c.hasListenerTargetBody),
-    hostListenerTargetParent: cmps.some((c) => c.hasListenerTargetParent),
     hostListenerTarget: cmps.some((c) => c.hasListenerTarget),
     member: cmps.some((c) => c.hasMember),
     method: cmps.some((c) => c.hasMethod),