fix(SSR): drop use client from components.server.ts#766
Open
mpesic wants to merge 1 commit into
Open
Conversation
Contributor
|
Any chance we can get this in? It is causing the hydrate script to be included in the client bundle for next.js |
236014b to
254492e
Compare
davidpett
approved these changes
Apr 28, 2026
Contributor
davidpett
left a comment
There was a problem hiding this comment.
I have patched this into my project's codebase and it works as expected
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally for affected output targetsnpm test) were run locally and passednpm run prettier) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Stencil-generated
components.server.tsincludes theuse clientdirective.Issue URL:
What is the new behavior?
components.server.tsexecutes in NodeJS environments and doesn't need theuse clientdirective.The
use clientconfuses Vite into thinking that react-output-target/ssr package executes on the client.Does this introduce a breaking change?
Other information