fix(react-runtime): temporary Vitest/jsdom compatibility shim for forwarded props#793
Open
mhoritani wants to merge 1 commit into
Open
fix(react-runtime): temporary Vitest/jsdom compatibility shim for forwarded props#793mhoritani wants to merge 1 commit into
mhoritani wants to merge 1 commit into
Conversation
Contributor
|
hey @mhoritani - thanks for looking at this, but it feels like the correct place for you to raise this would be in
|
Author
|
Upstream PR is now open in Lit: lit/lit#5325 Given feedback here, I’m treating that as the primary fix path and can follow up in output-targets based on the outcome upstream. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally for affected output targetsnpm test) were run locally and passednpm run prettier) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue URL: #791
In Vitest + jsdom, wrappers produced by
@stencil/react-output-targetcan lose forwarded element props likeid.The root of it is export resolution:
@lit/reacthas separatebrowserandnodeentries, and Vitest's transform context can pick thenodeentry. Thatnodepath is SSR-oriented and does not run the browser prop-application effect, so props classified as element props never land on the custom element in tests.What is the new behavior?
id) and custom element prototype property forwarding (object value path).packages/react/src/runtime/create-component.tswith a temporary compatibility shim aligned with@lit/reactbrowsercreate-componentbehavior.This is intentionally framed as a temporary compatibility layer, not a move away from Lit.
Does this introduce a breaking change?
Other information
@lit/reactprovides a stable way to preserve browser-style prop forwarding semantics in this Vitest/jsdom scenario, the shim should be removed and direct delegation can return.@lit/react. I did not want to block users on an uncertain upstream timeline, so this PR takes a short-term compatibility path.