Skip to content

Commit 4c26d3f

Browse files
author mentions removed
1 parent 606cbcb commit 4c26d3f

5 files changed

Lines changed: 8 additions & 13 deletions

File tree

README.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,9 @@
11
[![StepSecurity Maintained Action](https://raw.githubusercontent.com/step-security/maintained-actions-assets/main/assets/maintained-action-banner.png)](https://docs.stepsecurity.io/actions/stepsecurity-maintained-actions)
22

3-
<br/>
43
<p align="center">
54
<img alt="logo" src="./docs/assets/logo.png" width="320px"/>
65
<p align="center">Ensures the correctness of your CODEOWNERS file.</p>
76
</p>
8-
<br/>
97

108
## Codeowners Validator
119
<a href="/LICENSE"><img alt="Software License" src="https://img.shields.io/badge/license-Apache-brightgreen.svg?style=flat-square"/></a>

docs.json

Lines changed: 0 additions & 3 deletions
This file was deleted.

internal/check/duplicated_pattern.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ func NewDuplicatedPattern() *DuplicatedPattern {
2222
func (d *DuplicatedPattern) Check(ctx context.Context, in Input) (Output, error) {
2323
var bldr OutputBuilder
2424

25-
// TODO(mszostok): decide if the `CodeownersEntries` entry by default should be
25+
// TODO: decide if the `CodeownersEntries` entry by default should be
2626
// indexed by pattern (`map[string][]codeowners.Entry{}`)
2727
// Required changes in pkg/codeowners/owners.go.
2828
patterns := map[string][]codeowners.Entry{}

internal/check/valid_owner.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ func (v *ValidOwner) selectValidateFn(name string) func(context.Context, string)
161161
case isGitHubUser(name):
162162
return v.validateGitHubUser
163163
case isEmailAddress(name):
164-
// TODO(mszostok): try to check if e-mail really exists
164+
// TODO: try to check if e-mail really exists
165165
return func(context.Context, string) *validateError { return nil }
166166
default:
167167
return func(_ context.Context, name string) *validateError {
@@ -177,7 +177,7 @@ func (v *ValidOwner) initOrgListTeams(ctx context.Context) *validateError {
177177
}
178178
for {
179179
resultPage, resp, err := v.ghClient.Teams.ListTeams(ctx, v.orgName, req)
180-
if err != nil { // TODO(mszostok): implement retry?
180+
if err != nil { // TODO: implement retry?
181181
switch err := err.(type) {
182182
case *github.ErrorResponse:
183183
if err.Response.StatusCode == http.StatusUnauthorized {
@@ -235,10 +235,10 @@ func (v *ValidOwner) validateTeam(ctx context.Context, name string) *validateErr
235235
}
236236

237237
// repo contains the permissions for the team slug given
238-
// TODO(mszostok): Switch to GraphQL API, see:
238+
// TODO: Switch to GraphQL API, see:
239239
// https://github.com/mszostok/codeowners-validator/pull/62#discussion_r561273525
240240
repo, _, err := v.ghClient.Teams.IsTeamRepoBySlug(ctx, v.orgName, team, org, v.orgRepoName)
241-
if err != nil { // TODO(mszostok): implement retry?
241+
if err != nil { // TODO: implement retry?
242242
switch err := err.(type) {
243243
case *github.ErrorResponse:
244244
switch err.Response.StatusCode {
@@ -291,15 +291,15 @@ func (v *ValidOwner) validateTeam(ctx context.Context, name string) *validateErr
291291
}
292292

293293
func (v *ValidOwner) validateGitHubUser(ctx context.Context, name string) *validateError {
294-
if v.orgMembers == nil { // TODO(mszostok): lazy init, make it more robust.
294+
if v.orgMembers == nil { // TODO: lazy init, make it more robust.
295295
if err := v.initOrgListMembers(ctx); err != nil {
296296
return newValidateError("Cannot initialize organization member list: %v", err).AsPermanent()
297297
}
298298
}
299299

300300
userName := strings.TrimPrefix(name, "@")
301301
_, _, err := v.ghClient.Users.Get(ctx, userName)
302-
if err != nil { // TODO(mszostok): implement retry?
302+
if err != nil { // TODO: implement retry?
303303
switch err := err.(type) {
304304
case *github.ErrorResponse:
305305
if err.Response.StatusCode == http.StatusNotFound {

internal/runner/runner_worker.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ func NewCheckRunner(log logrus.FieldLogger, co []codeowners.Entry, repoPath stri
5757
func (r *CheckRunner) Run(ctx context.Context) {
5858
wg := sync.WaitGroup{}
5959

60-
// TODO(mszostok): timeout per check?
60+
// TODO: timeout per check?
6161
wg.Add(len(r.checks))
6262
for _, c := range r.checks {
6363
go func(c check.Checker) {

0 commit comments

Comments
 (0)