chore(mdm): use launchctl bootstrap/bootout instead of load/unload

Author: shubham-stepsecurity

internal/launchd/launchd.go

@@ -130,11 +130,19 @@ func Install(exec executor.Executor, log *progress.Logger) error {
 
 	log.Debug("launchd install: plist=%q log_dir=%q interval=%ds user_home=%q is_root=%v", plistPath, logDir, intervalSeconds, userHome, exec.IsRoot())
 
-	// Load plist
-	_, _, exitCode, err := exec.Run(ctx, "launchctl", "load", plistPath)
-	log.Debug("launchctl load %q: exit_code=%d err=%v", plistPath, exitCode, err)
+	// Bootstrap plist into its launchd domain. Apple actively recommends
+	// `bootstrap`/`bootout` over the older `load`/`unload` verbs, which
+	// are on the path to deprecation. Root daemons live in the `system`
+	// domain; user LaunchAgents in `gui/<uid>`. Available since macOS
+	// 10.11, so every machine we target supports it.
+	domain := "system"
+	if !exec.IsRoot() {
+		domain = fmt.Sprintf("gui/%d", os.Getuid())
+	}
+	_, _, exitCode, err := exec.Run(ctx, "launchctl", "bootstrap", domain, plistPath)
+	log.Debug("launchctl bootstrap %q %q: exit_code=%d err=%v", domain, plistPath, exitCode, err)
 	if err != nil || exitCode != 0 {
-		return fmt.Errorf("failed to load launchd configuration")
+		return fmt.Errorf("failed to bootstrap launchd configuration")
 	}
 
 	log.Progress("launchd configuration completed successfully")
@@ -164,11 +172,18 @@ func doUninstall(ctx context.Context, exec executor.Executor, log *progress.Logg
 		plistPath = agentPlistPath()
 	}
 
-	// Unload
+	// Bootout. `bootout` removes a service from its domain regardless of
+	// how it was originally added, so it works on plists previously
+	// `launchctl load`-ed by older agent versions during upgrade.
 	stdout, _, _, _ := exec.Run(ctx, "launchctl", "list")
 	if strings.Contains(stdout, label) {
-		_, _, exitCode, err := exec.Run(ctx, "launchctl", "unload", plistPath)
-		log.Debug("launchctl unload %q: exit_code=%d err=%v", plistPath, exitCode, err)
+		domain := "system"
+		if !exec.IsRoot() {
+			domain = fmt.Sprintf("gui/%d", os.Getuid())
+		}
+		target := domain + "/" + label
+		_, _, exitCode, err := exec.Run(ctx, "launchctl", "bootout", target)
+		log.Debug("launchctl bootout %q: exit_code=%d err=%v", target, exitCode, err)
 		log.Progress("Unloaded launchd agent")
 	}