Merge pull request #35 from shubham-stepsecurity/sm/update

feat: default quiet=false, raise S3 upload timeout to 10m, gofmt cleanup

Author: ashishkurmi

CHANGELOG.md

@@ -16,6 +16,11 @@ See [VERSIONING.md](VERSIONING.md) for why the version starts at 1.8.1.
 - **`--include-bundled-plugins` flag**: Bundled/platform plugins (e.g., Eclipse's 500+ OSGi bundles) are now filtered out by default to reduce noise and payload size (~124KB → ~21KB). Use the flag to include them.
 - **Sigstore signing retry logic**: Release workflow retries artifact signing with Sigstore on transient failures.
 
+### Changed
+
+- **Quiet mode now defaults to `false`**: Progress output is shown by default in community mode, matching the behavior already documented in the README. `configure` prompt and `configure show` now display `false` when the value is unset.
+- **S3 telemetry upload timeout increased from 60 seconds to 10 minutes**: Large scan payloads on slower networks were exhausting the previous 60 s budget and forcing the retry loop to redo the entire upload.
+
 ## [1.10.1] - 2026-04-21
 
 ### Added

cmd/stepsecurity-dev-machine-guard/main.go

@@ -56,7 +56,7 @@ func main() {
 	exec := executor.NewReal()
 
 	// Quiet resolution: config is the base, CLI overrides.
-	quiet := true
+	quiet := false
 	if config.Quiet != nil {
 		quiet = *config.Quiet
 	}

internal/cli/cli.go

@@ -11,17 +11,17 @@ import (
 
 // Config holds all parsed CLI flags.
 type Config struct {
-	Command          string   // "", "install", "uninstall", "send-telemetry", "configure", "configure show"
-	OutputFormat     string   // "pretty", "json", "html"
-	OutputFormatSet  bool     // true if --pretty/--json/--html was explicitly passed (not persisted)
-	HTMLOutputFile   string   // set by --html (not persisted)
-	ColorMode        string   // "auto", "always", "never"
-	Verbose          bool     // --verbose
-	EnableNPMScan        *bool    // nil=auto, true/false=explicit
-	EnableBrewScan       *bool    // nil=auto, true/false=explicit
-	EnablePythonScan     *bool    // nil=auto, true/false=explicit
-	IncludeBundledPlugins bool   // --include-bundled-plugins: include bundled/platform plugins in output
-	SearchDirs           []string // defaults to ["$HOME"]
+	Command               string   // "", "install", "uninstall", "send-telemetry", "configure", "configure show"
+	OutputFormat          string   // "pretty", "json", "html"
+	OutputFormatSet       bool     // true if --pretty/--json/--html was explicitly passed (not persisted)
+	HTMLOutputFile        string   // set by --html (not persisted)
+	ColorMode             string   // "auto", "always", "never"
+	Verbose               bool     // --verbose
+	EnableNPMScan         *bool    // nil=auto, true/false=explicit
+	EnableBrewScan        *bool    // nil=auto, true/false=explicit
+	EnablePythonScan      *bool    // nil=auto, true/false=explicit
+	IncludeBundledPlugins bool     // --include-bundled-plugins: include bundled/platform plugins in output
+	SearchDirs            []string // defaults to ["$HOME"]
 }
 
 // Parse parses CLI arguments and returns a Config.

internal/config/config.go

@@ -240,9 +240,9 @@ func RunConfigure() error {
 	}
 
 	// Quiet mode
-	currentQuiet := "true"
-	if existing.Quiet != nil && !*existing.Quiet {
-		currentQuiet = "false"
+	currentQuiet := "false"
+	if existing.Quiet != nil && *existing.Quiet {
+		currentQuiet = "true"
 	}
 	quietInput := promptValue(reader, "Quiet Mode (true/false)", currentQuiet)
 	switch strings.ToLower(quietInput) {
@@ -410,10 +410,10 @@ func displayOutputFormat(v string) string {
 }
 
 func displayQuiet(v *bool) string {
-	if v != nil && !*v {
-		return "false"
+	if v != nil && *v {
+		return "true"
 	}
-	return "true"
+	return "false"
 }
 
 func isPlaceholder(v string) bool {

internal/detector/eclipse_plugins.go

@@ -597,4 +597,3 @@ func parseEclipsePluginName(name string) *model.Extension {
 		IDEType:   "eclipse",
 	}
 }
-

internal/detector/eclipse_plugins_test.go

@@ -290,4 +290,3 @@ func TestFilterUserInstalledExtensions(t *testing.T) {
 		}
 	}
 }
-

internal/detector/ide.go

@@ -109,7 +109,7 @@ var ideDefinitions = []ideSpec{
 		WinPaths: []string{`%PROGRAMFILES%\JetBrains\GoLand *`},
 	},
 	{
-		AppName:      "Rider", IDEType: "rider", Vendor: "JetBrains",
+		AppName: "Rider", IDEType: "rider", Vendor: "JetBrains",
 		AppPath:      "/Applications/Rider.app",
 		WinPaths:     []string{`%PROGRAMFILES%\JetBrains\JetBrains Rider *`},
 		RegistryName: "JetBrains Rider",

internal/detector/jetbrains_test.go

@@ -409,20 +409,22 @@ type mockDirEntry struct {
 	isDir bool
 }
 
-func (e *mockDirEntry) Name() string              { return e.name }
-func (e *mockDirEntry) IsDir() bool               { return e.isDir }
-func (e *mockDirEntry) Type() os.FileMode         { return 0 }
-func (e *mockDirEntry) Info() (os.FileInfo, error) { return &testFileInfo{name: e.name, dir: e.isDir}, nil }
+func (e *mockDirEntry) Name() string      { return e.name }
+func (e *mockDirEntry) IsDir() bool       { return e.isDir }
+func (e *mockDirEntry) Type() os.FileMode { return 0 }
+func (e *mockDirEntry) Info() (os.FileInfo, error) {
+	return &testFileInfo{name: e.name, dir: e.isDir}, nil
+}
 
 // testFileInfo implements os.FileInfo for testing.
 type testFileInfo struct {
 	name string
 	dir  bool
 }
 
-func (fi *testFileInfo) Name() string      { return fi.name }
-func (fi *testFileInfo) Size() int64       { return 0 }
-func (fi *testFileInfo) IsDir() bool       { return fi.dir }
+func (fi *testFileInfo) Name() string       { return fi.name }
+func (fi *testFileInfo) Size() int64        { return 0 }
+func (fi *testFileInfo) IsDir() bool        { return fi.dir }
 func (fi *testFileInfo) ModTime() time.Time { return time.Time{} }
 func (fi *testFileInfo) Mode() os.FileMode  { return 0o644 }
 func (fi *testFileInfo) Sys() any           { return nil }

internal/detector/nodescan.go

@@ -90,7 +90,6 @@ func (s *NodeScanner) runInDir(ctx context.Context, dir string, timeout time.Dur
 	return s.exec.RunInDir(ctx, dir, timeout, name, args...)
 }
 
-
 // checkPath checks if a binary is available, using the logged-in user's PATH when running as root.
 func (s *NodeScanner) checkPath(ctx context.Context, name string) error {
 	if s.shouldRunAsUser() {

internal/scan/scanner.go

@@ -261,4 +261,3 @@ func mcpConfigsToCommunity(configs []model.MCPConfig) []model.MCPConfig {
 	}
 	return configs
 }
-