Skip to content

feat(windows): eclipse plugin detection #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ashishkurmi merged 10 commits into from
Apr 21, 2026
Merged

feat(windows): eclipse plugin detection #32

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
3429665
fix(windows): add Windows Eclipse plugin detection paths
swarit-stepsecurity Apr 21, 2026
16c90a1
fix(windows): Eclipse plugin detection uses detected IDE install paths
swarit-stepsecurity Apr 21, 2026
9165fda
feat(windows): robust multi-stage Eclipse plugin detection
swarit-stepsecurity Apr 21, 2026
eb751bb
fix(eclipse): expand bundled prefix list to accurately identify marke…
swarit-stepsecurity Apr 21, 2026
46ef8f5
feat(eclipse): use p2 director API for authoritative marketplace plug…
swarit-stepsecurity Apr 21, 2026
3cb22fd
feat: filter bundled plugins by default, add --include-bundled-plugin…
swarit-stepsecurity Apr 21, 2026
6f3a22b
fix: scope bundled plugin filter to Windows only
swarit-stepsecurity Apr 21, 2026
ed292a6
feat(windows): eclipse plugin detection
swarit-stepsecurity Apr 21, 2026
5891fc7
fix(lint): remove unused eclipseExePatterns and resolveEclipseFeature…
swarit-stepsecurity Apr 21, 2026
79b1250
fix: address Copilot review comments on PR #32
swarit-stepsecurity Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions internal/cli/cli.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,11 @@ type Config struct {
HTMLOutputFile string // set by --html (not persisted)
ColorMode string // "auto", "always", "never"
Verbose bool // --verbose
EnableNPMScan *bool // nil=auto, true/false=explicit
EnableBrewScan *bool // nil=auto, true/false=explicit
EnablePythonScan *bool // nil=auto, true/false=explicit
SearchDirs []string // defaults to ["$HOME"]
EnableNPMScan *bool // nil=auto, true/false=explicit
EnableBrewScan *bool // nil=auto, true/false=explicit
EnablePythonScan *bool // nil=auto, true/false=explicit
IncludeBundledPlugins bool // --include-bundled-plugins: include bundled/platform plugins in output
SearchDirs []string // defaults to ["$HOME"]
}

// Parse parses CLI arguments and returns a Config.
Expand Down Expand Up @@ -83,6 +84,8 @@ func Parse(args []string) (*Config, error) {
case arg == "--disable-python-scan":
v := false
cfg.EnablePythonScan = &v
case arg == "--include-bundled-plugins":
cfg.IncludeBundledPlugins = true
Comment on lines +87 to +88
Copy link

Copilot AI Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new --include-bundled-plugins flag is parsed, but it isn’t shown in printHelp() under Options. This makes the flag hard to discover and can lead to confusion when users run --help.

Copilot uses AI. Check for mistakes.
case strings.HasPrefix(arg, "--color="):
mode := strings.TrimPrefix(arg, "--color=")
if mode != "auto" && mode != "always" && mode != "never" {
Expand Down
Loading
Loading