Select module import

+ feature no longer requires preview flag!
+ update tests 23 -> 25

Fixes eclipse-jdt#4371

Author: stephan-herrmann

org.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/model/AllJavaModelTests.java

@@ -116,7 +116,7 @@ private static Class[] getAllTestClasses() {
 		ResolveTests10.class,
 		ResolveTests12To15.class,
 		ResolveTests21.class,
-		ResolveTests23.class,
+		ResolveTests25.class,
 		SelectionJavadocModelTests.class,
 
 		// Some test suite above breaks completion tests below

…jdt/core/tests/model/ResolveTests23.java …jdt/core/tests/model/ResolveTests25.javaorg.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/model/ResolveTests23.java renamed to org.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/model/ResolveTests25.java org.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/model/ResolveTests23.java renamed to org.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/model/ResolveTests25.java

@@ -19,11 +19,10 @@
 import org.eclipse.core.runtime.CoreException;
 import org.eclipse.jdt.core.ICompilationUnit;
 import org.eclipse.jdt.core.IJavaElement;
-import org.eclipse.jdt.core.JavaCore;
 import org.eclipse.jdt.core.JavaModelException;
 import org.eclipse.jdt.core.WorkingCopyOwner;
 
-public class ResolveTests23 extends AbstractJavaModelTests {
+public class ResolveTests25 extends AbstractJavaModelTests {
 	ICompilationUnit wc = null;
 
 static {
@@ -32,9 +31,9 @@ public class ResolveTests23 extends AbstractJavaModelTests {
 	// TESTS_RANGE = new int[] { 16, -1 };
 }
 public static Test suite() {
-	return buildModelTestSuite(ResolveTests23.class);
+	return buildModelTestSuite(ResolveTests25.class);
 }
-public ResolveTests23(String name) {
+public ResolveTests25(String name) {
 	super(name);
 }
 @Override
@@ -44,8 +43,7 @@ public ICompilationUnit getWorkingCopy(String path, String source) throws JavaMo
 @Override
 public void setUpSuite() throws Exception {
 	super.setUpSuite();
-	this.currentProject = setUpJavaProject("Resolve", "23", false);
-	this.currentProject.setOption(JavaCore.COMPILER_PB_ENABLE_PREVIEW_FEATURES, JavaCore.ENABLED);
+	this.currentProject = setUpJavaProject("Resolve", "25", false);
 	waitUntilIndexesReady();
 }
 @Override

org.eclipse.jdt.core/codeassist/org/eclipse/jdt/internal/codeassist/SelectionEngine.java

@@ -953,7 +953,7 @@ public void select(
 						if (importReference instanceof SelectionOnImportReference) {
 							char[][] tokens = ((SelectionOnImportReference) importReference).tokens;
 							this.noProposal = false;
-							if ((importReference.modifiers & ClassFileConstants.AccModule) != 0 && this.compilerOptions.enablePreviewFeatures) {
+							if ((importReference.modifiers & ClassFileConstants.AccModule) != 0) {
 								this.nameEnvironment.findModules(CharOperation.concatWithAll(tokens, '.'), this, null);
 								return;
 							}