fix qualifier issue#338
Open
stephanenicolas wants to merge 1 commit into
Open
Conversation
Collaborator
|
RTM |
stephanenicolas
force-pushed
the
sni/fix-qualifier-name-issue-328
branch
from
24a9a78 to
9296709
Compare
Owner
Author
|
@dlemures can you re-check it please? The new version is much cleaner. The initial tests were not in the right test class. |
Collaborator
|
RTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a little thing wrong in the case of a qualifier being an internal class. The compiler was using
getName()from the annotation processing API which translates, not intogetName()at runtime time butgetCanonicalName().Tests have been updated, and the API is more complete to use qualifiers to getInstance/Provider/Lazy using TP.