Split up glaze/json/generic.hpp#2560
Merged
Merged
Conversation
makekryl
force-pushed
the
split-generic-header
branch
from
420da2d to
4af169b
Compare
Owner
|
Thanks for this! I'm pretty busy right now, but I'll check it over and try to get it merged soon. |
The push of warning 4456 lived in generic_def.hpp but the matching pop was in generic.hpp, so including generic_def.hpp standalone (the documented use case for forward-declaring generic in public headers) leaked the disabled warning into the rest of the translation unit.
Parallels the existing glaze/forward.hpp convention: both headers exist so that widely-included user code can reference Glaze types without pulling in read/write machinery, with full inclusion deferred to the TUs that actually serialize. The documentation now lists which operations work with the lightweight header versus which require the full glaze/json/generic.hpp, and shows the intended public-header / .cpp split as a worked example. A cross-reference is added in glaze/forward.hpp so users discovering one of the two paired headers can find the other.
Owner
|
I renamed to "generic_fwd.hpp" and fixed an MSVC macro issue, but it looks good, so I'm merging now. |
Contributor
Author
|
Sorry, I totally forgot about the macro Thank you! |
Owner
|
No problem, thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.