Skip to content

FIX: github workflow macos build#2301

Merged
NeoPlays merged 4 commits into
stereum-dev:mainfrom
NeoPlays:fix-macos-build
May 18, 2026
Merged

FIX: github workflow macos build#2301
NeoPlays merged 4 commits into
stereum-dev:mainfrom
NeoPlays:fix-macos-build

Conversation

@NeoPlays

@NeoPlays NeoPlays commented May 18, 2026

Copy link
Copy Markdown
Member

FIX: workflow build

Fixes the --universal macOS build, which was failing with:

Expected all non-binary files to have identical SHAs when creating a universal build but "Contents/Frameworks/Electron Framework.framework/Versions/A/_CodeSignature/CodeResources" did not

Background

The previous commit added an afterPack hook to ad-hoc re-sign unsigned macOS builds for macOS 26+ Team ID compatibility. However, afterPack fires once per arch on the temporary per-arch outputs before @electron/universal merges them. Re-signing those temps produces different CodeResources files between x64 and arm64, causing the universal merge to fail.

Changes

launcher/afterPackMac.jslauncher/afterSignMac.js (renamed)

  • Hook function renamed afterPackMacafterSignMac, log prefixes updated to match.
  • Added a comment explaining why this must run as afterSign rather than afterPack: afterSign fires once on the final merged universal .app, after the merge succeeds.

launcher/vue.config.js

  • Replaced the separate afterSign (notarize) and afterPack (re-sign) entries with a single conditional afterSign entry:
    • shouldNotarize → notarize plugin (signed + notarized builds).
    • !isSigned./afterSignMac.js (unsigned builds).
    • Otherwise → no hook.
  • Since both hooks now use the same afterSign slot, they're mutually exclusive by design (you'd never need both at once).

Result

  • Unsigned --universal builds: re-sign now runs on the merged universal .app instead of the per-arch temps, so the merge succeeds and the resulting app launches on macOS 14.4+ / 26+.
  • Signed/notarized builds: behavior unchanged.

@NeoPlays NeoPlays merged commit 4899b43 into stereum-dev:main May 18, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant