FIX: github workflow macos build#2301
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FIX: workflow build
Fixes the
--universalmacOS build, which was failing with:Background
The previous commit added an
afterPackhook to ad-hoc re-sign unsigned macOS builds for macOS 26+ Team ID compatibility. However,afterPackfires once per arch on the temporary per-arch outputs before@electron/universalmerges them. Re-signing those temps produces differentCodeResourcesfiles between x64 and arm64, causing the universal merge to fail.Changes
launcher/afterPackMac.js→launcher/afterSignMac.js(renamed)afterPackMac→afterSignMac, log prefixes updated to match.afterSignrather thanafterPack:afterSignfires once on the final merged universal.app, after the merge succeeds.launcher/vue.config.jsafterSign(notarize) andafterPack(re-sign) entries with a single conditionalafterSignentry:shouldNotarize→ notarize plugin (signed + notarized builds).!isSigned→./afterSignMac.js(unsigned builds).afterSignslot, they're mutually exclusive by design (you'd never need both at once).Result
--universalbuilds: re-sign now runs on the merged universal.appinstead of the per-arch temps, so the merge succeeds and the resulting app launches on macOS 14.4+ / 26+.