Fix beman-tidy lint failures

steve-downey · steve-downey · commit 07bce97150ea · 2026-06-30T23:42:00.000-04:00
Add missing SPDX-License-Identifier headers, a beman::optional CMake
alias target, and the required README badge link so beman-tidy's
Requirement checks pass. Rename two test files to the *.test.cpp
convention. Also exclude build/cache/venv/infra/papers directories in
.beman-tidy.yaml so local pre-commit runs aren't swamped by false
positives from generated or vendored content.
diff --git a/.beman-tidy.yaml b/.beman-tidy.yaml
@@ -1,2 +1,9 @@
+# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+
 ignored_paths:
   - installtest/
+  - .build/
+  - .cache/
+  - .venv/
+  - infra/
+  - papers/
diff --git a/.github/dependabot.yml b/.github/dependabot.yml
@@ -1,3 +1,5 @@
+# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+
 # To get started with Dependabot version updates, you'll need to specify which
 # package ecosystems to update and where the package manifests are located.
 # Please see the documentation for all configuration options:
diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml
@@ -1,4 +1,6 @@
 ---
+# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+
 # For most projects, this workflow file will not need changing; you simply need
 # to commit it to your repository.
 #
diff --git a/.github/workflows/doxygen-gh-pages.yml b/.github/workflows/doxygen-gh-pages.yml
@@ -1,3 +1,5 @@
+# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+
 name: Doxygen GitHub Pages Deploy Action
 
 on:
diff --git a/.github/workflows/ossf-scorecard-analysis.yml b/.github/workflows/ossf-scorecard-analysis.yml
@@ -1,3 +1,5 @@
+# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+
 name: Scorecard analysis workflow
 on:
   push:
diff --git a/.github/workflows/pre-commit-check.yml b/.github/workflows/pre-commit-check.yml
@@ -1,3 +1,5 @@
+# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+
 name: Lint Check (pre-commit)
 
 on:
diff --git a/.github/workflows/pre-commit.yml b/.github/workflows/pre-commit.yml
@@ -1,3 +1,5 @@
+# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+
 name: pre-commit
 
 on:
diff --git a/.markdownlint.yaml b/.markdownlint.yaml
@@ -1,3 +1,5 @@
+# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+
 # MD033/no-inline-html : Inline HTML : https://github.com/DavidAnson/markdownlint/blob/v0.35.0/doc/md033.md
 # Disable inline html linter is needed for <details> <summary>
 MD033: false
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -1,3 +1,5 @@
+# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+
 # See https://pre-commit.com for more information
 # See https://pre-commit.com/hooks.html for more hooks
 repos:
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -21,6 +21,7 @@ set(CMAKE_VERIFY_INTERFACE_HEADER_SETS ON)
 
 # Create the library target and named header set for beman.optional
 add_library(beman.optional INTERFACE)
+add_library(beman::optional ALIAS beman.optional)
 target_sources(
     beman.optional
     PUBLIC FILE_SET beman_optional_headers TYPE HEADERS BASE_DIRS include
diff --git a/README.md b/README.md
@@ -5,7 +5,7 @@ SPDX-License-Identifier: 2.0 license with LLVM exceptions
 -->
 
 <!-- markdownlint-disable -->
-![Library Status](https://raw.githubusercontent.com/bemanproject/beman/refs/heads/main/images/badges/beman_badge-beman_library_production_ready_api_may_undergo_changes.svg)![Standard Target](https://github.com/bemanproject/beman/blob/main/images/badges/cpp26.svg)[![Compiler Explorer Example](https://img.shields.io/badge/Try%20it%20on%20Compiler%20Explorer-grey?logo=compilerexplorer&logoColor=67c52a)](https://godbolt.org/z/Gc6Y9j6zf)
+[![Library Status](https://raw.githubusercontent.com/bemanproject/beman/refs/heads/main/images/badges/beman_badge-beman_library_production_ready_api_may_undergo_changes.svg)](https://github.com/bemanproject/beman/blob/main/docs/beman_library_maturity_model.md#the-beman-library-maturity-model)![Standard Target](https://github.com/bemanproject/beman/blob/main/images/badges/cpp26.svg)[![Compiler Explorer Example](https://img.shields.io/badge/Try%20it%20on%20Compiler%20Explorer-grey?logo=compilerexplorer&logoColor=67c52a)](https://godbolt.org/z/Gc6Y9j6zf)
 <!-- markdownlint-enable -->
 
 This repository implements `std::optional` extensions targeting C++26. The `beman.optional` library aims to evaluate the stability, the usability, and the performance of these proposed changes before they are officially adopted by WG21 into the C++ Working Draft. Additionally, it allows developers to use these new features before they are implemented in major standard library compilers.
diff --git a/cmake/use-fetch-content.cmake b/cmake/use-fetch-content.cmake
@@ -1,3 +1,6 @@
+# cmake/use-fetch-content.cmake                                     -*-cmake-*-
+# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+
 cmake_minimum_required(VERSION 3.24)
 
 if(NOT BEMAN_OPTIONAL_LOCKFILE)
diff --git a/docs/mrdocs.yml b/docs/mrdocs.yml
@@ -1,3 +1,5 @@
+# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+
 # $schema: https://mrdocs.com/docs/mrdocs/develop/_attachments/mrdocs.schema.json
 # yaml-language-server: $schema=https://mrdocs.com/docs/mrdocs/develop/_attachments/mrdocs.schema.json
 
diff --git a/etc/ci-clang-toolchain.cmake b/etc/ci-clang-toolchain.cmake
@@ -1,3 +1,8 @@
+# cmake-format: off
+# etc/ci-clang-toolchain.cmake -*-cmake-*-
+# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+# cmake-format: on
+
 include_guard(GLOBAL)
 
 set(CMAKE_C_COMPILER clang)
diff --git a/etc/clang-16-toolchain.cmake b/etc/clang-16-toolchain.cmake
@@ -1,3 +1,8 @@
+# cmake-format: off
+# etc/clang-16-toolchain.cmake -*-cmake-*-
+# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+# cmake-format: on
+
 include_guard(GLOBAL)
 
 set(CMAKE_C_COMPILER clang-16)
diff --git a/etc/clang-17-toolchain.cmake b/etc/clang-17-toolchain.cmake
@@ -1,3 +1,8 @@
+# cmake-format: off
+# etc/clang-17-toolchain.cmake -*-cmake-*-
+# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+# cmake-format: on
+
 include_guard(GLOBAL)
 
 set(CMAKE_C_COMPILER clang-17)
diff --git a/etc/clang-18-toolchain.cmake b/etc/clang-18-toolchain.cmake
@@ -1,3 +1,8 @@
+# cmake-format: off
+# etc/clang-18-toolchain.cmake -*-cmake-*-
+# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+# cmake-format: on
+
 include_guard(GLOBAL)
 
 set(CMAKE_C_COMPILER clang-18)
diff --git a/etc/clang-19-toolchain.cmake b/etc/clang-19-toolchain.cmake
@@ -1,3 +1,8 @@
+# cmake-format: off
+# etc/clang-19-toolchain.cmake -*-cmake-*-
+# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+# cmake-format: on
+
 include_guard(GLOBAL)
 
 set(CMAKE_C_COMPILER clang-19)
diff --git a/etc/clang-flags.cmake b/etc/clang-flags.cmake
@@ -1,3 +1,8 @@
+# cmake-format: off
+# etc/clang-flags.cmake -*-cmake-*-
+# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+# cmake-format: on
+
 include_guard(GLOBAL)
 
 set(CMAKE_CXX_STANDARD 20)
diff --git a/etc/gcc-12-toolchain.cmake b/etc/gcc-12-toolchain.cmake
@@ -1,3 +1,8 @@
+# cmake-format: off
+# etc/gcc-12-toolchain.cmake -*-cmake-*-
+# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+# cmake-format: on
+
 include_guard(GLOBAL)
 
 include("${CMAKE_CURRENT_LIST_DIR}/gcc-flags.cmake")
diff --git a/etc/gcc-13-toolchain.cmake b/etc/gcc-13-toolchain.cmake
@@ -1,3 +1,8 @@
+# cmake-format: off
+# etc/gcc-13-toolchain.cmake -*-cmake-*-
+# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+# cmake-format: on
+
 include_guard(GLOBAL)
 
 include("${CMAKE_CURRENT_LIST_DIR}/gcc-flags.cmake")
diff --git a/etc/gcc-14-toolchain.cmake b/etc/gcc-14-toolchain.cmake
@@ -1,3 +1,8 @@
+# cmake-format: off
+# etc/gcc-14-toolchain.cmake -*-cmake-*-
+# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+# cmake-format: on
+
 include_guard(GLOBAL)
 
 include("${CMAKE_CURRENT_LIST_DIR}/gcc-flags.cmake")
diff --git a/etc/gcc-15-toolchain.cmake b/etc/gcc-15-toolchain.cmake
@@ -1,3 +1,8 @@
+# cmake-format: off
+# etc/gcc-15-toolchain.cmake -*-cmake-*-
+# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+# cmake-format: on
+
 include_guard(GLOBAL)
 
 include("${CMAKE_CURRENT_LIST_DIR}/gcc-flags.cmake")
diff --git a/etc/gcc-16-toolchain.cmake b/etc/gcc-16-toolchain.cmake
@@ -1,3 +1,8 @@
+# cmake-format: off
+# etc/gcc-16-toolchain.cmake -*-cmake-*-
+# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+# cmake-format: on
+
 include_guard(GLOBAL)
 
 include("${CMAKE_CURRENT_LIST_DIR}/gcc-flags.cmake")
diff --git a/etc/gcc-flags.cmake b/etc/gcc-flags.cmake
@@ -1,3 +1,8 @@
+# cmake-format: off
+# etc/gcc-flags.cmake -*-cmake-*-
+# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+# cmake-format: on
+
 include_guard(GLOBAL)
 
 set(CMAKE_CXX_STANDARD 20)
diff --git a/etc/gcc-toolchain.cmake b/etc/gcc-toolchain.cmake
@@ -1,3 +1,8 @@
+# cmake-format: off
+# etc/gcc-toolchain.cmake -*-cmake-*-
+# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+# cmake-format: on
+
 include_guard(GLOBAL)
 
 set(CMAKE_C_COMPILER gcc)
diff --git a/etc/llvm-16-toolchain.cmake b/etc/llvm-16-toolchain.cmake
@@ -1,3 +1,8 @@
+# cmake-format: off
+# etc/llvm-16-toolchain.cmake -*-cmake-*-
+# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+# cmake-format: on
+
 include_guard(GLOBAL)
 
 set(CMAKE_C_COMPILER clang-16)
diff --git a/etc/llvm-master-toolchain.cmake b/etc/llvm-master-toolchain.cmake
@@ -1,3 +1,8 @@
+# cmake-format: off
+# etc/llvm-master-toolchain.cmake -*-cmake-*-
+# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+# cmake-format: on
+
 set(LLVM_ROOT "$ENV{LLVM_ROOT}" CACHE PATH "Path to LLVM installation")
 
 set(CMAKE_C_COMPILER ${LLVM_ROOT}/bin/clang)
diff --git a/etc/llvm-toolchain.cmake b/etc/llvm-toolchain.cmake
@@ -1,3 +1,8 @@
+# cmake-format: off
+# etc/llvm-toolchain.cmake -*-cmake-*-
+# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+# cmake-format: on
+
 include_guard(GLOBAL)
 
 set(CMAKE_C_COMPILER clang-14)
diff --git a/etc/toolchain.cmake b/etc/toolchain.cmake
@@ -1,3 +1,8 @@
+# cmake-format: off
+# etc/toolchain.cmake -*-cmake-*-
+# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+# cmake-format: on
+
 include_guard(GLOBAL)
 
 include("${CMAKE_CURRENT_LIST_DIR}/gcc-flags.cmake")
diff --git a/include/beman/optional/detail/stl_interfaces/config.hpp b/include/beman/optional/detail/stl_interfaces/config.hpp
@@ -1,4 +1,5 @@
 // include/beman/optional/detail/stl_interfaces/config.hpp            -*-C++-*-
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 
 // Copyright (C) 2020 T. Zachary Laine
 //
diff --git a/include/beman/optional/detail/stl_interfaces/fwd.hpp b/include/beman/optional/detail/stl_interfaces/fwd.hpp
@@ -1,4 +1,5 @@
 // include/beman/optional/detail/stl_interfaces/fwd.hpp               -*-C++-*-
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 
 // Copyright (C) 2019 T. Zachary Laine
 //
diff --git a/include/beman/optional/detail/stl_interfaces/iterator_interface.hpp b/include/beman/optional/detail/stl_interfaces/iterator_interface.hpp
@@ -1,4 +1,5 @@
 // include/beman/optional/detail/stl_interfaces/iterator_interface.hpp -*-C++-*-
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 
 // Copyright (C) 2019 T. Zachary Laine
 //
diff --git a/scripts/install_run_precommit.sh b/scripts/install_run_precommit.sh
@@ -1,4 +1,6 @@
 #!/usr/bin/env bash
+# scripts/install_run_precommit.sh                                    -*-shell-*-
+# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 # shellcheck disable=SC1091
 
 python3 -m venv .venv
diff --git a/tests/beman/optional/CMakeLists.txt b/tests/beman/optional/CMakeLists.txt
@@ -25,7 +25,7 @@ target_link_libraries(
     PRIVATE beman.optional GTest::gtest GTest::gtest_main
 )
 
-add_library(constructor_fails test_constructor_fail.cpp)
+add_library(constructor_fails test_constructor_fail.test.cpp)
 
 target_link_libraries(constructor_fails PRIVATE beman.optional)
 
diff --git a/tests/beman/optional/detail/iterator.test.cpp b/tests/beman/optional/detail/iterator.test.cpp
@@ -1,4 +1,4 @@
-// tests/beman/optional/detail/iterator.t.cpp -*-C++-*-
+// tests/beman/optional/detail/iterator.test.cpp -*-C++-*-
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 
 /**
diff --git a/tests/beman/optional/test_constructor_fail.test.cpp b/tests/beman/optional/test_constructor_fail.test.cpp

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception`
	`2`	`+`
`1`	`3`	`# To get started with Dependabot version updates, you'll need to specify which`
`2`	`4`	`# package ecosystems to update and where the package manifests are located.`
`3`	`5`	`# Please see the documentation for all configuration options:`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,6 @@`
`1`	`1`	`---`
	`2`	`+# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception`
	`3`	`+`
`2`	`4`	`# For most projects, this workflow file will not need changing; you simply need`
`3`	`5`	`# to commit it to your repository.`
`4`	`6`	`#`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception`
	`2`	`+`
`1`	`3`	`name: Doxygen GitHub Pages Deploy Action`
`2`	`4`
`3`	`5`	`on:`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception`
	`2`	`+`
`1`	`3`	`name: Scorecard analysis workflow`
`2`	`4`	`on:`
`3`	`5`	`push:`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception`
	`2`	`+`
`1`	`3`	`name: Lint Check (pre-commit)`
`2`	`4`
`3`	`5`	`on:`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception`
	`2`	`+`
`1`	`3`	`name: pre-commit`
`2`	`4`
`3`	`5`	`on:`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception`
	`2`	`+`
`1`	`3`	`# MD033/no-inline-html : Inline HTML : https://github.com/DavidAnson/markdownlint/blob/v0.35.0/doc/md033.md`
`2`	`4`	`# Disable inline html linter is needed for <details> <summary>`
`3`	`5`	`MD033: false`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception`
	`2`	`+`
`1`	`3`	`# See https://pre-commit.com for more information`
`2`	`4`	`# See https://pre-commit.com/hooks.html for more hooks`
`3`	`5`	`repos:`