fix: use os path when watching for changes#744
Open
BrownBuilding wants to merge 2 commits intostevearc:masterfrom
Open
fix: use os path when watching for changes#744BrownBuilding wants to merge 2 commits intostevearc:masterfrom
BrownBuilding wants to merge 2 commits intostevearc:masterfrom
Conversation
Call `fs.posix_to_os_path` on the path parsed from the `oil://*`-url before handing it off to uv.fs_event_start. Not doing so breaks watch_for_changes on MS Windows. (On Windows `oil://C/mydir/subdir/` would cause uv.fs_event_start to be called with `C/mydir/subdir/` rather than `C:\mydir\subdir\`)
Author
|
the top level drive view breaks on windows |
Make sure not to register an fs_event for '/' on windows, since posix_to_os_path will throw an error, preventing the top level windows drives from being shown.
barrettruth
added a commit
to barrettruth/canola.nvim
that referenced
this pull request
Apr 27, 2026
Problem: `doc/upstream.md` still listed upstream PR stevearc#744 as open after opening the corresponding main-branch fix in this fork. That leaves the tracker out of sync with the actual resolution work. Solution: update the upstream PR table to point stevearc#744 at fork PR #320 so the tracker reflects the active fix branch and review thread.
barrettruth
added a commit
to barrettruth/canola.nvim
that referenced
this pull request
Apr 27, 2026
* fix(view): normalize windows watch paths Problem: `watch_for_changes` passes parsed buffer URLs directly to `uv.fs_event_start`, which breaks Windows watcher setup because libuv expects an OS path. The synthetic Windows drive-list buffer also tries to watch `/`, which is not a real directory. Solution: convert the parsed directory with `fs.posix_to_os_path()` before starting the watcher and skip watcher setup for the Windows drive-list buffer. Add focused specs that cover both the converted watch path and the root-buffer guard. * docs(upstream): mark stevearc#744 fixed Problem: `doc/upstream.md` still listed upstream PR stevearc#744 as open after opening the corresponding main-branch fix in this fork. That leaves the tracker out of sync with the actual resolution work. Solution: update the upstream PR table to point stevearc#744 at fork PR #320 so the tracker reflects the active fix branch and review thread.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Call
fs.posix_to_os_pathon the path parsed from theoil://*-url before handing it off to uv.fs_event_start. Not doing so breakswatch_for_changeson MS Windows.(On Windows
oil://C/mydir/subdir/would causeuv.fs_event_startto be called withC/mydir/subdir/rather thanC:\mydir\subdir\)