Dispose of pre-existing tasks before loading in tasks from resession#370
Open
Jackaed wants to merge 2 commits into
Open
Dispose of pre-existing tasks before loading in tasks from resession#370Jackaed wants to merge 2 commits into
Jackaed wants to merge 2 commits into
Conversation
…en restoring from resession
stevearc
requested changes
Oct 17, 2024
stevearc
left a comment
stevearc
left a comment
Owner
There was a problem hiding this comment.
This seems like a fine option to have, but it should be controlled by a config option and shouldn't be the default behavior. There are a lot of different ways that sessions can be used and a lot of different possible tasks that people could be running. We shouldn't terminate them unless explicitly requested.
Comment on lines
+25
to
+31
| while true do | ||
| local task = task_list.get_by_index(1) | ||
| if task == nil then | ||
| break | ||
| end | ||
| task:dispose(true) | ||
| end |
Owner
There was a problem hiding this comment.
It would be safer to get the tasks with overseer.list_tasks, iterate over those, and dispose each of them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disposes of all tasks before loading in tasks from resession. May want to be placed behind an configuration option (I'm happy to implement that if you'd like), but this functionality seems far more sane to me than how it currently works - I don't see why you'd want to preserve pre-existing tasks when switching projects and loading in the tasks for that project.