rsession extension does not persist non-default task components added before session save#506
Open
michaelcosj wants to merge 1 commit into
Conversation
…ault task components added before session save
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Resession extension not persisting non-default task components
This PR fixes a bug where custom components added to tasks (such as
restart_on_save) were not being restored when loading a session with the resession extension.When tasks with custom components were saved and later loaded from a resession session, those components would be lost. For example, if a user added a
restart_on_savecomponent to a task, after restoring the session, that task would no longer restart on file save.Task:serialize()properly saves all serializable components to thecomponentsfieldoverseer.new_task(params)is calledoverseer.new_task()has special handling forfrom_templatetasks that bypasses the normalTask.new()flow where components are addedparams.componentscontaining the serialized custom components was never processedAdded an explicit call to
task:add_components(params.components)after loading the task on the extension, ensuring all serialized components are properly restored.closes #507