Skip to content

Commit e44d48f

Browse files
steveisokCopilot
andcommitted
Re-enable FEATURE_CORPROFILER for tvOS to match iOS/MacCatalyst
PR dotnet#126550 disabled FEATURE_CORPROFILER for tvOS but left iOS, MacCatalyst, and Android commented out (profiler still enabled). There is no reason to single out tvOS from its sibling Apple mobile platforms. They should be treated as a package deal. The uncommented 'AND NOT CLR_CMAKE_TARGET_TVOS' line removed profiler fields from the Thread struct on tvOS, making the hardcoded OFFSETOF__Thread__m_pInterpThreadContext in asmconstants.h wrong (0x2b8 vs actual 0x228), breaking all 3 tvOS legs in unified-build. Comment out the tvOS line to match iOS/MacCatalyst/Android, keeping the profiler enabled until all mobile platforms disable it together. Fixes internal unified-build tvOS failures on main (build 2946990). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 5889432 commit e44d48f

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

src/coreclr/clrfeatures.cmake

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,8 @@ if(NOT DEFINED FEATURE_CORPROFILER)
5252
# AND NOT CLR_CMAKE_TARGET_ANDROID
5353
# AND NOT CLR_CMAKE_TARGET_MACCATALYST
5454
# AND NOT CLR_CMAKE_TARGET_IOS
55-
AND NOT CLR_CMAKE_TARGET_TVOS)
55+
# AND NOT CLR_CMAKE_TARGET_TVOS
56+
)
5657
set(FEATURE_CORPROFILER 1)
5758
endif()
5859
endif()

0 commit comments

Comments
 (0)