Fix for screenshots

Author: stever

apps/gif-service/src/gif-generator.ts

@@ -265,6 +265,7 @@ export class GIFGenerator {
         const ff = spawn('ffmpeg', args, { stdio: ['pipe', 'ignore', 'pipe'] });
         let stderr = '';
         ff.stderr.on('data', (d) => { stderr += d.toString(); });
+        ff.stdin.on('error', () => undefined); // EPIPE if ffmpeg exits early; close handler reports status
 
         const finished = new Promise<void>((resolve, reject) => {
             ff.on('error', reject);
@@ -322,6 +323,9 @@ export class GIFGenerator {
         const ff = spawn('ffmpeg', args, { stdio: ['pipe', 'ignore', 'pipe'] });
         let stderr = '';
         ff.stderr.on('data', (d) => { stderr += d.toString(); });
+        // If ffmpeg exits early the stdin write EPIPEs; swallow it (the close
+        // handler reports the real status) so it can't crash the process.
+        ff.stdin.on('error', () => undefined);
         const finished = new Promise<void>((resolve, reject) => {
             ff.on('error', reject);
             ff.on('close', (code) =>

apps/gif-service/src/index.ts

@@ -5,6 +5,12 @@ import projectRoutes from './routes/project.js';
 import sourceRoutes from './routes/source.js';
 import screenshotRoutes from './routes/screenshot.js';
 
+// Safety net: a single bad render must never take down the whole service. Log
+// and keep serving rather than letting an unhandled error exit the process
+// (each request is independent and stateless).
+process.on('unhandledRejection', (reason) => console.error('Unhandled rejection:', reason));
+process.on('uncaughtException', (err) => console.error('Uncaught exception:', err));
+
 const app = express();
 const PORT = process.env.PORT || 5001;
 

apps/gif-service/src/routes/screenshot.ts

@@ -63,7 +63,11 @@ router.get('/:id', async (req: Request, res: Response) => {
                     return out;
                 });
                 inFlight.set(key, pending);
-                pending.finally(() => inFlight.delete(key));
+                // Clear the slot when done. The trailing .catch is essential: the
+                // real error is surfaced via `await pending` below, but this
+                // derived promise would otherwise reject unhandled and crash the
+                // process (Node exits on unhandledRejection).
+                pending.finally(() => inFlight.delete(key)).catch(() => undefined);
             }
             png = await pending;
         }