Implement OpenID Connect Discovery#24
Closed
FWest98 wants to merge 14 commits intosteverhoades:masterfrom
Closed
Conversation
Owner
|
@FWest98 Thank you for the PR, I apologize for the delay in the review. If it's not too much trouble can you add some documentation to the Readme? Once that is done it looks good to me. |
The new version of lcobucci/jwt seems convert timestamps to DateTimeImmutable. All the code currently expects a unix timestamp so this breaks. Fixed by simply checking for DateTimeInterface and converting them back to unix timestamps before validation.
Replace the Token interface with Plain because we need to use claims(), which only exist on Plain anyway. Getting any other token now throws errors. Also assert that our token type, AccessToken is returned in getAccessToken. This helps with static analysis tools and IDE autocomplete both for us and users.
Both 4.0 and 4.1 work
Author
|
Well.. For an entire year I was thinking you asked for unit tests instead of documentation..... But now I decided to add both and finally update the MR! |
…nid-connect-client into fw/discovery-php8
|
@steverhoades @FWest98 What's the status of this MR? :) |
Author
|
As far as I'm concerned, this is ready to merge, but I guess by now there are merge conflicts. I will try to fix those in the coming days |
Author
|
Please refer to #37 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements support for automatic discovery of OpenID Connect configuration, as specified here.
Fixes #22
Details: adds an
issuerconfiguration field, which, when present, will cause the provider to dynamically set all other options based on the data at the<issuer>/.well-known/openid-configurationendpoint. This includes public key configuration.