refactor: build command paths more efficiently

steverusso · steverusso · commit ab0d53001112 · 2025-05-25T17:24:37.000-04:00
diff --git a/builder.go b/builder.go
@@ -146,7 +146,8 @@ func (c CommandInfo) Subcmd(sc CommandInfo) CommandInfo {
 		panic(errMixingPosArgsAndSubcmds)
 	}
 
-	sc.Path = append([]string(nil), c.Path...)
+	sc.Path = make([]string, len(c.Path))
+	copy(sc.Path, c.Path)
 	sc.Path = append(sc.Path, sc.Name)
 
 	c.Subcmds = append(c.Subcmds, sc)

Original file line number	Diff line number	Diff line change
`@@ -146,7 +146,8 @@ func (c CommandInfo) Subcmd(sc CommandInfo) CommandInfo {`
`146`	`146`	`panic(errMixingPosArgsAndSubcmds)`
`147`	`147`	`}`
`148`	`148`
`149`		`- sc.Path = append([]string(nil), c.Path...)`
	`149`	`+ sc.Path = make([]string, len(c.Path))`
	`150`	`+ copy(sc.Path, c.Path)`
`150`	`151`	`sc.Path = append(sc.Path, sc.Name)`
`151`	`152`
`152`	`153`	`c.Subcmds = append(c.Subcmds, sc)`