Skip to content

fix(alert): remove extra alert div #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stevologic merged 1 commit into from
Jul 28, 2025
Merged

fix(alert): remove extra alert div #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 2 additions & 22 deletions ui/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ function App() {
setAlerts((prev) => [...prev, msg]);
}, []);
const [bellBounce, setBellBounce] = React.useState(false);
const [showAlert, setShowAlert] = React.useState(false);
const [search, setSearch] = React.useState("");
const [expanded, setExpanded] = React.useState({});
const [collapsed, setCollapsed] = React.useState({});
Expand Down Expand Up @@ -346,7 +345,6 @@ function App() {
let msg =
e.message || (e.reason && e.reason.message) || String(e.reason || e);
addAlert(msg);
setShowAlert(true);
};
window.addEventListener("error", errHandler);
window.addEventListener("unhandledrejection", errHandler);
Expand All @@ -362,7 +360,6 @@ function App() {
origError.apply(console, args);
const msg = args.map((a) => (a && a.message) || a).join(" ");
addAlert(String(msg));
setShowAlert(true);
};
return () => {
console.error = origError;
Expand Down Expand Up @@ -401,13 +398,6 @@ function App() {
}
}, [alerts]);

React.useEffect(() => {
if (alerts.length > 0) {
setShowAlert(true);
const t = setTimeout(() => setShowAlert(false), 3000);
return () => clearTimeout(t);
}
}, [alerts]);

React.useEffect(() => {
if (loading && statusMessages.length > 1) {
Expand Down Expand Up @@ -688,7 +678,6 @@ function App() {

setCacheStatus("");

setShowAlert(false);

let ver = forcedVer !== null ? forcedVer : version;
if (!ver) {
Expand All @@ -703,7 +692,7 @@ function App() {
const controller = new AbortController();
const timer = setTimeout(() => {
addAlert("Request timed out. Some dependencies may be missing.");
setShowAlert(true);

controller.abort();
}, 60000);
abortRef.current = { controller, timer };
Expand Down Expand Up @@ -1462,12 +1451,6 @@ function App() {
return e(
"div",
null,
showAlert &&
e(
"div",
{ className: "alert-toast" },
alerts.map((msg, i) => e("div", { key: i }, msg))
),
loading &&
e(
"div",
Expand Down Expand Up @@ -1546,11 +1529,9 @@ function App() {
"span",
{
className: "alert-icon-container",
onMouseEnter: () => alerts.length && setShowAlert(true),
onMouseLeave: () => alerts.length && setShowAlert(false),

onClick: () => {
if (alerts.length) setAlerts([]);
setShowAlert(false);
},
},
e("img", {
Expand All @@ -1560,7 +1541,6 @@ function App() {
alerts.length > 0 &&
e("span", { className: "notification-badge" }),
alerts.length > 0 &&
showAlert &&
e(
"div",
{ className: "alert-box" },
Expand Down
Loading