Merge pull request #3440 from stfc/test_fparser

Update to fparser 0.2.4

Author: arporter

.github/workflows/compilation.yml

@@ -87,7 +87,7 @@ jobs:
         python -m pip install --upgrade pip
         # Uncomment the below to use the submodule version of fparser rather
         # than the latest release from pypi.
-        pip install external/fparser
+        # pip install external/fparser
         pip install .[test,psydata,doc,treesitter]
     - name: Unit tests with compilation - gfortran
       run: |

.github/workflows/extraction_test.yml

@@ -74,7 +74,7 @@ jobs:
         python -m pip install --upgrade pip
         # Uncomment the below to use the submodule version of fparser rather
         # than the latest release from pypi.
-        pip install external/fparser
+        # pip install external/fparser
         pip install .[test]
         # Install BAF, and its version of Fab:
         # ------------------------------------

.github/workflows/lfric_test.yml

@@ -85,7 +85,7 @@ jobs:
         python -m pip install --upgrade pip
         # Uncomment the below to use the submodule version of fparser rather
         # than the latest release from pypi.
-        pip install external/fparser
+        # pip install external/fparser
         pip install .[test]
         # Fetch the specified version of LFRic apps
         cd /archive/psyclone-tests/latest-run

.github/workflows/nemo_tests.yml

@@ -86,7 +86,7 @@ jobs:
         python -m pip install --upgrade pip
         # Uncomment the below to use the submodule version of fparser rather
         # than the latest release from pypi.
-        pip install external/fparser
+        # pip install external/fparser
         pip install .[test]
         # Compile nvidia profiling tools
         module load nvidia-hpcsdk/${NVFORTRAN_VERSION}

.github/workflows/nemo_v5_tests.yml

@@ -83,7 +83,7 @@ jobs:
         python -m pip install --upgrade pip
         # Uncomment the below to use the submodule version of fparser rather
         # than the latest release from pypi.
-        pip install external/fparser
+        # pip install external/fparser
         pip install .
     - name: Reset working directory
       run: |

.github/workflows/python-package.yml

@@ -63,12 +63,27 @@ jobs:
       GITHUB_PR_NUMBER: ${{ github.event.number }}
     steps:
       - uses: actions/checkout@v4
+        with:
+          submodules: recursive
+          # This is required to get the commit history for merge commits for
+          # the ci-skip check below.
+          fetch-depth: '0'
+      - name: Check for [skip ci] in commit message
+        uses: mstachniuk/ci-skip@v1
+        with:
+          # This setting causes the tests to 'fail' if [skip ci] is specified
+          fail-fast: true
+          commit-filter: '[skip ci]'
       - uses: actions/setup-python@v5
         with:
           python-version: '3.14'
       - run: sudo apt-get install -y graphviz doxygen
       - run: python -m pip install --upgrade pip
-      - run: pip install .[doc]
+      - run: |
+          # Uncomment the below to use the submodule version of fparser rather
+          # than the latest release from pypi.
+          # pip install external/fparser
+          pip install .[doc]
       # Now we can check for warnings and broken links
       - run: cd doc; make html SPHINXOPTS="-W --keep-going"
       - run: cd doc; make linkcheck
@@ -102,10 +117,10 @@ jobs:
           python -m pip install --upgrade pip
           # Some of the examples use Jupyter.
           pip install jupyter
-          # We need to install sphinx to get correct doc testing
           # Uncomment the below to use the submodule version of fparser rather
           # than the latest release from pypi.
           # pip install external/fparser
+          # We need to install sphinx to get correct doc testing
           pip install .[doc]
           pip install .[test,treesitter]
       - name: Lint with flake8

changelog

@@ -1,3 +1,5 @@
+   34) PR #3440. Update to use release 0.2.4 of fparser.
+ 
    33) PR #3467. Update CI compilers.
 
    32) PR #3458 for #2721. Adds ArrayConstructor support into the PSyIR.

external/fparser

@@ -66,7 +66,7 @@ classifiers = [
 ]
 dependencies = [
     "pyparsing",
-    "fparser==0.2.2",
+    "fparser==0.2.4",
     "configparser",
     "sympy",
     "Jinja2",

pyproject.toml

@@ -123,9 +123,9 @@ def test_generate_lfric_adjoint_no_routines_error(fortran_reader):
 
 MULTI_ROUTINE_CODE = (
     f"module test_mod\n"
-    f"  implicit none\n"
     f"  use kernel_mod\n"
     f"  use argument_mod\n"
+    f"  implicit none\n"
     f"{METADATA}"
     f"  public test_code\n"
     f"  interface test_code\n"
@@ -187,9 +187,9 @@ def test_generate_lfric_adjoint_multi_routine_logging(fortran_reader, caplog):
 
 SINGLE_ROUTINE_CODE = (
     "module test_mod\n"
-    "  implicit none\n"
     "  use kernel_mod\n"
     "  use argument_mod\n"
+    "  implicit none\n"
     "  type, extends(kernel_type) :: test_type\n"
     "     type(arg_type), dimension(2) :: meta_args = (/  &\n"
     "          arg_type(gh_field,  gh_real, gh_inc, w0),  &\n"