(Towards #3463) Reverse the order of operations to build the region in reverse#3464
Open
LonelyCat124 wants to merge 2 commits into
Open
(Towards #3463) Reverse the order of operations to build the region in reverse#3464LonelyCat124 wants to merge 2 commits into
LonelyCat124 wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3464 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 393 393
Lines 55067 55067
=========================================
Hits 55067 55067 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sergisiso
requested changes
Jun 30, 2026
sergisiso
left a comment
sergisiso
left a comment
Collaborator
There was a problem hiding this comment.
@LonelyCat124 There is a small comment but I am ok with this change and it is already tested by all the maximal_region_trans_test examples. So this can be merged after the release.
| all_blocks = [] | ||
| current_block = [] | ||
| for child in node_list: | ||
| for child in node_list[::-1]: |
Collaborator
There was a problem hiding this comment.
Maybe reversed(node_list) ?
Collaborator
Author
There was a problem hiding this comment.
Yeah this is probably more efficient than making a new list since we don't modify, done.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple PR to reverse the order in which maximal parallel region trans build their regions. I expect to need this to work out if assignments can be in parallel regions and its probably a more sensible default way to build these regions.
Ready for a review from @arporter or @sergisiso . I considered using a
deque, however I would have ended up needing to cast thedequeto alistenough times I didn't think it would save anything.